From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Subject: Re: [PATCH net-next 2/3] arm64: dts: fsl: ls1028a-rdb: Add ENETC external eth ports for the LS1028A RDB board Date: Thu, 14 Feb 2019 17:27:46 +0100 Message-ID: <20190214162746.GI708@lunn.ch> References: <1550055743-15542-1-git-send-email-claudiu.manoil@nxp.com> <1550055743-15542-3-git-send-email-claudiu.manoil@nxp.com> <20190213181554.GB708@lunn.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Claudiu Manoil Cc: "devicetree@vger.kernel.org" , "netdev@vger.kernel.org" , Alexandru Marginean , "linux-kernel@vger.kernel.org" , Leo Li , Shawn Guo , "David S . Miller" , "linux-arm-kernel@lists.infradead.org" List-Id: devicetree@vger.kernel.org > Hi Andrew, > > The extra node for mdio seems to complicate things somewhat. > Just adding this node seems not enough. How to find out easily if a child > of a enetc port node is a mdio node? You copy somebody else code :-) https://elixir.bootlin.com/linux/v5.0-rc6/source/drivers/net/dsa/mv88e6xxx/chip.c#L2765 Andrew