[PATCH v2 0/2] Add Reset controller support for HI3670 SoC

devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed

* [PATCH v2 0/2] Add Reset controller support for HI3670 SoC
@ 2019-02-15  5:49 Manivannan Sadhasivam
  2019-02-15  5:49 ` [PATCH v2 1/2] dt-bindings: reset: Add HI3670 reset controller binding Manivannan Sadhasivam
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Manivannan Sadhasivam @ 2019-02-15  5:49 UTC (permalink / raw)
  To: p.zabel, xuwei5, robh+dt
  Cc: linux-arm-kernel, devicetree, linux-kernel, guodong.xu,
	john.stultz, Manivannan Sadhasivam

Hello,

This patchset adds Reset controller support for HiSilicon HI3670 SoC.
HI3670 SoC is architecturally same as HI3660 SoC, hence the same driver
is reused.

This patchset has been tested on HiKey970 board.

Thanks,
Mani

Changes in v2:

* Used the DT compatible fallback approach instead of adding a new one
  for HI3670

Manivannan Sadhasivam (2):
  dt-bindings: reset: Add HI3670 reset controller binding
  arm64: dts: hisilicon: hi3670: Add reset controller support

 .../devicetree/bindings/reset/hisilicon,hi3660-reset.txt   | 7 ++++---
 arch/arm64/boot/dts/hisilicon/hi3670.dtsi                  | 6 ++++++
 2 files changed, 10 insertions(+), 3 deletions(-)

-- 
2.17.1

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH v2 1/2] dt-bindings: reset: Add HI3670 reset controller binding
  2019-02-15  5:49 [PATCH v2 0/2] Add Reset controller support for HI3670 SoC Manivannan Sadhasivam
@ 2019-02-15  5:49 ` Manivannan Sadhasivam
  2019-02-15 10:25   ` Philipp Zabel
  2019-02-18 20:08   ` Rob Herring
  2019-02-15  5:49 ` [PATCH v2 2/2] arm64: dts: hisilicon: hi3670: Add reset controller support Manivannan Sadhasivam
  2019-04-15 15:53 ` [PATCH v2 0/2] Add Reset controller support for HI3670 SoC Wei Xu
  2 siblings, 2 replies; 6+ messages in thread
From: Manivannan Sadhasivam @ 2019-02-15  5:49 UTC (permalink / raw)
  To: p.zabel, xuwei5, robh+dt
  Cc: linux-arm-kernel, devicetree, linux-kernel, guodong.xu,
	john.stultz, Manivannan Sadhasivam

HI3670 SoC is architecturally same as the HI3660 SoC. Hence, the same
driver is reused for HI3670 SoC and the binding is documented here which
uses the fallback approach.

Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
---
 .../devicetree/bindings/reset/hisilicon,hi3660-reset.txt   | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/reset/hisilicon,hi3660-reset.txt b/Documentation/devicetree/bindings/reset/hisilicon,hi3660-reset.txt
index 2bf3344b2a02..2df4bddeb688 100644
--- a/Documentation/devicetree/bindings/reset/hisilicon,hi3660-reset.txt
+++ b/Documentation/devicetree/bindings/reset/hisilicon,hi3660-reset.txt
@@ -5,11 +5,12 @@ Please also refer to reset.txt in this directory for common reset
 controller binding usage.
 
 The reset controller registers are part of the system-ctl block on
-hi3660 SoC.
+hi3660 and hi3670 SoCs.
 
 Required properties:
-- compatible: should be
-		 "hisilicon,hi3660-reset"
+- compatible: should be one of the following:
+		 "hisilicon,hi3660-reset" for HI3660
+		 "hisilicon,hi3670-reset", "hisilicon,hi3660-reset" for HI3670
 - hisi,rst-syscon: phandle of the reset's syscon.
 - #reset-cells : Specifies the number of cells needed to encode a
   reset source.  The type shall be a <u32> and the value shall be 2.
-- 
2.17.1

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH v2 1/2] dt-bindings: reset: Add HI3670 reset controller binding
  2019-02-15  5:49 ` [PATCH v2 1/2] dt-bindings: reset: Add HI3670 reset controller binding Manivannan Sadhasivam
@ 2019-02-15 10:25   ` Philipp Zabel
  2019-02-18 20:08   ` Rob Herring
  1 sibling, 0 replies; 6+ messages in thread
From: Philipp Zabel @ 2019-02-15 10:25 UTC (permalink / raw)
  To: Manivannan Sadhasivam, xuwei5, robh+dt
  Cc: linux-arm-kernel, devicetree, linux-kernel, guodong.xu,
	john.stultz

On Fri, 2019-02-15 at 11:19 +0530, Manivannan Sadhasivam wrote:
> HI3670 SoC is architecturally same as the HI3660 SoC. Hence, the same
> driver is reused for HI3670 SoC and the binding is documented here which
> uses the fallback approach.
> 
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> ---
>  .../devicetree/bindings/reset/hisilicon,hi3660-reset.txt   | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/reset/hisilicon,hi3660-reset.txt b/Documentation/devicetree/bindings/reset/hisilicon,hi3660-reset.txt
> index 2bf3344b2a02..2df4bddeb688 100644
> --- a/Documentation/devicetree/bindings/reset/hisilicon,hi3660-reset.txt
> +++ b/Documentation/devicetree/bindings/reset/hisilicon,hi3660-reset.txt
> @@ -5,11 +5,12 @@ Please also refer to reset.txt in this directory for common reset
>  controller binding usage.
>  
>  The reset controller registers are part of the system-ctl block on
> -hi3660 SoC.
> +hi3660 and hi3670 SoCs.
>  
>  Required properties:
> -- compatible: should be
> -		 "hisilicon,hi3660-reset"
> +- compatible: should be one of the following:
> +		 "hisilicon,hi3660-reset" for HI3660
> +		 "hisilicon,hi3670-reset", "hisilicon,hi3660-reset" for HI3670
>  - hisi,rst-syscon: phandle of the reset's syscon.
>  - #reset-cells : Specifies the number of cells needed to encode a
>    reset source.  The type shall be a <u32> and the value shall be 2.

Thank you, I think it makes sense for this to be merged together with
the other patch via the linux-hisi tree.

Acked-by: Philipp Zabel <p.zabel@pengutronix.de>

regards
Philipp

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v2 1/2] dt-bindings: reset: Add HI3670 reset controller binding
  2019-02-15  5:49 ` [PATCH v2 1/2] dt-bindings: reset: Add HI3670 reset controller binding Manivannan Sadhasivam
  2019-02-15 10:25   ` Philipp Zabel
@ 2019-02-18 20:08   ` Rob Herring
  1 sibling, 0 replies; 6+ messages in thread
From: Rob Herring @ 2019-02-18 20:08 UTC (permalink / raw)
  Cc: p.zabel, xuwei5, robh+dt, linux-arm-kernel, devicetree,
	linux-kernel, guodong.xu, john.stultz, Manivannan Sadhasivam

On Fri, 15 Feb 2019 11:19:54 +0530, Manivannan Sadhasivam wrote:
> HI3670 SoC is architecturally same as the HI3660 SoC. Hence, the same
> driver is reused for HI3670 SoC and the binding is documented here which
> uses the fallback approach.
> 
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> ---
>  .../devicetree/bindings/reset/hisilicon,hi3660-reset.txt   | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 

Reviewed-by: Rob Herring <robh@kernel.org>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH v2 2/2] arm64: dts: hisilicon: hi3670: Add reset controller support
  2019-02-15  5:49 [PATCH v2 0/2] Add Reset controller support for HI3670 SoC Manivannan Sadhasivam
  2019-02-15  5:49 ` [PATCH v2 1/2] dt-bindings: reset: Add HI3670 reset controller binding Manivannan Sadhasivam
@ 2019-02-15  5:49 ` Manivannan Sadhasivam
  2019-04-15 15:53 ` [PATCH v2 0/2] Add Reset controller support for HI3670 SoC Wei Xu
  2 siblings, 0 replies; 6+ messages in thread
From: Manivannan Sadhasivam @ 2019-02-15  5:49 UTC (permalink / raw)
  To: p.zabel, xuwei5, robh+dt
  Cc: linux-arm-kernel, devicetree, linux-kernel, guodong.xu,
	john.stultz, Manivannan Sadhasivam

Add reset controller support for HiSilicon HI3670 SoC.

Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
---
 arch/arm64/boot/dts/hisilicon/hi3670.dtsi | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/arch/arm64/boot/dts/hisilicon/hi3670.dtsi b/arch/arm64/boot/dts/hisilicon/hi3670.dtsi
index a5bd6d80b226..2af88c429c97 100644
--- a/arch/arm64/boot/dts/hisilicon/hi3670.dtsi
+++ b/arch/arm64/boot/dts/hisilicon/hi3670.dtsi
@@ -151,6 +151,12 @@
 			#clock-cells = <1>;
 		};
 
+		crg_rst: crg_rst_controller {
+			compatible = "hisilicon,hi3670-reset", "hisilicon,hi3660-reset";
+			#reset-cells = <2>;
+			hisi,rst-syscon = <&crg_ctrl>;
+		};
+
 		pctrl: pctrl@e8a09000 {
 			compatible = "hisilicon,hi3670-pctrl", "syscon";
 			reg = <0x0 0xe8a09000 0x0 0x1000>;
-- 
2.17.1

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH v2 0/2] Add Reset controller support for HI3670 SoC
  2019-02-15  5:49 [PATCH v2 0/2] Add Reset controller support for HI3670 SoC Manivannan Sadhasivam
  2019-02-15  5:49 ` [PATCH v2 1/2] dt-bindings: reset: Add HI3670 reset controller binding Manivannan Sadhasivam
  2019-02-15  5:49 ` [PATCH v2 2/2] arm64: dts: hisilicon: hi3670: Add reset controller support Manivannan Sadhasivam
@ 2019-04-15 15:53 ` Wei Xu
  2 siblings, 0 replies; 6+ messages in thread
From: Wei Xu @ 2019-04-15 15:53 UTC (permalink / raw)
  To: Manivannan Sadhasivam, p.zabel, robh+dt
  Cc: linux-arm-kernel, devicetree, linux-kernel, guodong.xu,
	john.stultz, xuwei5

Hi Manivannan,

On 2/15/2019 5:49 AM, Manivannan Sadhasivam wrote:
> Hello,
> 
> This patchset adds Reset controller support for HiSilicon HI3670 SoC.
> HI3670 SoC is architecturally same as HI3660 SoC, hence the same driver
> is reused.
> 
> This patchset has been tested on HiKey970 board.
> 
> Thanks,
> Mani
> 
> Changes in v2:
> 
> * Used the DT compatible fallback approach instead of adding a new one
>   for HI3670
> 
> Manivannan Sadhasivam (2):
>   dt-bindings: reset: Add HI3670 reset controller binding
>   arm64: dts: hisilicon: hi3670: Add reset controller support
> 
>  .../devicetree/bindings/reset/hisilicon,hi3660-reset.txt   | 7 ++++---
>  arch/arm64/boot/dts/hisilicon/hi3670.dtsi                  | 6 ++++++
>  2 files changed, 10 insertions(+), 3 deletions(-)
> 

Thanks!
Applied the series to the hisilicon dts tree.

Best Regards,
Wei

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2019-04-15 15:53 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-02-15  5:49 [PATCH v2 0/2] Add Reset controller support for HI3670 SoC Manivannan Sadhasivam
2019-02-15  5:49 ` [PATCH v2 1/2] dt-bindings: reset: Add HI3670 reset controller binding Manivannan Sadhasivam
2019-02-15 10:25   ` Philipp Zabel
2019-02-18 20:08   ` Rob Herring
2019-02-15  5:49 ` [PATCH v2 2/2] arm64: dts: hisilicon: hi3670: Add reset controller support Manivannan Sadhasivam
2019-04-15 15:53 ` [PATCH v2 0/2] Add Reset controller support for HI3670 SoC Wei Xu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).