From: marek.vasut@gmail.com
To: devicetree@vger.kernel.org
Cc: Marek Vasut <marek.vasut+renesas@gmail.com>,
Harald Geyer <harald@ccbib.org>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Linus Walleij <linus.walleij@linaro.org>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
linux-renesas-soc@vger.kernel.org
Subject: [PATCH] regulator: gpio: Reword the binding document
Date: Sat, 16 Feb 2019 18:48:59 +0100 [thread overview]
Message-ID: <20190216174859.15738-1-marek.vasut@gmail.com> (raw)
From: Marek Vasut <marek.vasut+renesas@gmail.com>
Reword the binding document to make it clear how the propeties work
and which properties affect which other properties.
Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>
Cc: Harald Geyer <harald@ccbib.org>
Cc: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Mark Brown <broonie@kernel.org>
Cc: Rob Herring <robh@kernel.org>
Cc: linux-renesas-soc@vger.kernel.org
To: devicetree@vger.kernel.org
---
Note: The recent gpio-regulator rework caused breakage. While the
changes in the gpio-regulator code were according to the DT
binding document, they stopped working with older DTs. Make
the binding document clearer to prevent such breakage in the
future.
---
.../bindings/regulator/gpio-regulator.txt | 23 +++++++++++++------
1 file changed, 16 insertions(+), 7 deletions(-)
diff --git a/Documentation/devicetree/bindings/regulator/gpio-regulator.txt b/Documentation/devicetree/bindings/regulator/gpio-regulator.txt
index 1f496159e2bb..acca13c1eaf3 100644
--- a/Documentation/devicetree/bindings/regulator/gpio-regulator.txt
+++ b/Documentation/devicetree/bindings/regulator/gpio-regulator.txt
@@ -4,16 +4,25 @@ Required properties:
- compatible : Must be "regulator-gpio".
- regulator-name : Defined in regulator.txt as optional, but required
here.
-- states : Selection of available voltages and GPIO configs.
- if there are no states, then use a fixed regulator
+- states : Selection of available voltages/currents provided by
+ this regulator and matching GPIO configurations to
+ achieve them. If there are no states in the "states"
+ array, use a fixed regulator instead.
Optional properties:
-- enable-gpio : GPIO to use to enable/disable the regulator.
-- gpios : GPIO group used to control voltage.
-- gpios-states : gpios pin's initial states array. 0: LOW, 1: HIGH.
- defualt is LOW if nothing is specified.
+- enable-gpio : GPIO used to enable/disable the regulator.
+ Warning, the GPIO phandle flags are ignored and the
+ GPIO polarity is controlled solely by the presence
+ of "enable-active-high" DT property. This is due to
+ compatibility with old DTs.
+- enable-active-high : Polarity of "enable-gpio" GPIO is active HIGH.
+ Default is active LOW.
+- gpios : Array of one or more GPIO pins used to select the
+ regulator voltage/current listed in "states".
+- gpios-states : Initial state of GPIO pins in "gpios" array.
+ 0: LOW, 1: HIGH.
+ Default is LOW if nothing else is specified.
- startup-delay-us : Startup time in microseconds.
-- enable-active-high : Polarity of GPIO is active high (default is low).
- regulator-type : Specifies what is being regulated, must be either
"voltage" or "current", defaults to voltage.
--
2.19.2
next reply other threads:[~2019-02-16 17:48 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-16 17:48 marek.vasut [this message]
2019-02-16 20:20 ` [PATCH] regulator: gpio: Reword the binding document Harald Geyer
2019-02-16 21:37 ` Marek Vasut
2019-02-17 14:26 ` Harald Geyer
2019-02-17 14:45 ` Marek Vasut
2019-02-17 20:00 ` Harald Geyer
2019-02-17 21:57 ` Marek Vasut
2019-02-18 10:04 ` Harald Geyer
2019-02-18 18:58 ` Marek Vasut
2019-02-18 22:18 ` Harald Geyer
2019-02-19 2:51 ` Marek Vasut
2019-02-19 10:10 ` Harald Geyer
2019-03-02 14:55 ` Marek Vasut
2019-03-03 16:07 ` Harald Geyer
2019-03-03 16:08 ` Marek Vasut
2019-02-18 18:01 ` Mark Brown
2019-02-18 17:56 ` Mark Brown
2019-02-18 17:54 ` Mark Brown
2019-02-18 9:30 ` Geert Uytterhoeven
2019-02-18 18:36 ` Marek Vasut
2019-02-18 19:21 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190216174859.15738-1-marek.vasut@gmail.com \
--to=marek.vasut@gmail.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=harald@ccbib.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linus.walleij@linaro.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=marek.vasut+renesas@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).