From: Lee Jones <lee.jones@linaro.org>
To: Moritz Fischer <moritz.fischer@ettus.com>
Cc: Virendra Kakade <virendra.kakade@ni.com>,
Devicetree List <devicetree@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux PM <linux-pm@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Sebastian Reichel <sre@kernel.org>
Subject: Re: [RFC 2/6] mfd: Support for Ettus Research E31x devices PMU
Date: Mon, 18 Feb 2019 08:56:45 +0000 [thread overview]
Message-ID: <20190218085645.GA4118@dell> (raw)
In-Reply-To: <CAAtXAHemEOOKOmQGT5StDt-Jxn0RUOoc9L-breMNURhd8=9q=Q@mail.gmail.com>
On Sun, 17 Feb 2019, Moritz Fischer wrote:
> On Thu, Feb 14, 2019 at 1:34 AM Lee Jones <lee.jones@linaro.org> wrote:
> > On Mon, 11 Feb 2019, Virendra Kakade wrote:
> >
> > > Signed-off-by: Virendra Kakade <virendra.kakade@ni.com>
> > > ---
> > > drivers/mfd/Kconfig | 7 +++
> > > drivers/mfd/Makefile | 2 +-
> > > drivers/mfd/e31x-pmu.c | 89 ++++++++++++++++++++++++++++++++++++
> > > include/linux/mfd/e31x-pmu.h | 20 ++++++++
> > > 4 files changed, 117 insertions(+), 1 deletion(-)
> > > create mode 100644 drivers/mfd/e31x-pmu.c
> > > create mode 100644 include/linux/mfd/e31x-pmu.h
[...]
Try not to quote too many unnecessary lines when replying please.
> > So the whole purpose of this driver is to do a version check.
> >
> > Seems like over-kill!
> >
> > Probably better to do the version check in an inline function stored
> > in a header file, then call it from each of the children's .probe()
> > function.
>
> A bit of context here, this is based on an in-house driver that we had that does
> a bunch of other stuff (e.g. it controls a flag on whether the device auto-boots
> on power being plugged in etc.). These functions will use the regmap.
>
> I had advised Virendra to submit a base version and follow up with patches
> that would add these functions one by one as he figures out how to expose them
> in a proper way to the kernel.
Probably best to wait until you have something a little more
featureful before attempting to upstream then. I couldn't tell you
how many times I've had contributors tell me that they plan to follow
up with additional patches and (for their own perfectly decent reasons
I'm sure) fail to do so.
As it stands, this driver over-kill for what you're trying to achieve
and therefore isn't overly suitable for upstreaming at the moment.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2019-02-18 8:56 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-12 1:01 [RFC 0/6] Add support for Ettus Research E31x devices PMU Virendra Kakade
2019-02-12 1:01 ` [RFC 1/6] mfd: Support " Virendra Kakade
2019-02-12 10:51 ` Moritz Fischer
2019-02-14 9:23 ` Lee Jones
2019-02-12 1:01 ` [RFC 2/6] " Virendra Kakade
2019-02-14 9:34 ` Lee Jones
2019-02-17 16:37 ` Moritz Fischer
2019-02-18 8:56 ` Lee Jones [this message]
2019-02-12 1:01 ` [RFC 3/6] power: supply: Ettus Research E31x charger driver Virendra Kakade
2019-02-14 9:38 ` Lee Jones
2019-02-25 23:38 ` Rob Herring
2019-02-12 1:01 ` [RFC 4/6] " Virendra Kakade
2019-02-12 21:46 ` Sebastian Reichel
2019-02-12 1:01 ` [RFC 5/6] power: supply: Ettus Research E31x battery driver Virendra Kakade
2019-02-14 9:39 ` Lee Jones
2019-02-12 1:01 ` [RFC 6/6] " Virendra Kakade
2019-02-12 22:26 ` Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190218085645.GA4118@dell \
--to=lee.jones@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=moritz.fischer@ettus.com \
--cc=robh+dt@kernel.org \
--cc=sre@kernel.org \
--cc=virendra.kakade@ni.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).