From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Subject: Re: [PATCH 4/4] arm64: dts: allwinner: h6: Add CPU Operating Performance Points table Date: Mon, 18 Feb 2019 10:33:40 +0100 Message-ID: <20190218093340.jcggm7jplpwrogsv@flea> References: <20190214130910.9201-1-tiny.windzz@gmail.com> <20190214130910.9201-5-tiny.windzz@gmail.com> <20190214143842.nqsh6trwdjxq2ecd@flea> <20190215135613.sdz56vtiawqeryi5@flea> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="i5c56aqsedye5nda" Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Frank Lee Cc: Chen-Yu Tsai , robh+dt@kernel.org, mark.rutland@arm.com, Linux ARM , devicetree@vger.kernel.org, Linux Kernel Mailing List List-Id: devicetree@vger.kernel.org --i5c56aqsedye5nda Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Fri, Feb 15, 2019 at 10:09:51PM +0800, Frank Lee wrote: > On Fri, Feb 15, 2019 at 9:56 PM Maxime Ripard = wrote: > > > > Hi > > > > On Fri, Feb 15, 2019 at 12:56:03AM +0800, Frank Lee wrote: > > > How about to implement a thermal driver that is not integrated with > > > gpadc =EF=BC=9F > > > > > > GPADC on soc is rarely used now. > > > > You mean GPADC in general, or the gpadc driver in particular? > > Otherwise, yes, having a driver for the thermal sensor in the H6 > > sounds like a good plan for thermal throttling, but I don't see it as > > a dependency for that whole series. > > At present, sunxi's thermal driver is integrated with the gpadc driver. > I have a idea to implement the thermal driver alone. I haven't started ye= t, > and it may take a while to do it. >=20 > How about the plan to implement a thermal drive alone and put i > under drivers/thermal? The Thermal Sensor is basically a stripped down GPADC, which is why it would make sense to have a single driver. There was a pending series doing this that could be a good idea to improve and merge: https://lkml.org/lkml/2018/8/30/729 Maxime --=20 Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --i5c56aqsedye5nda Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXGp78wAKCRDj7w1vZxhR xYT8AQDFxHvCKmLk+1YErRAvdFGGHBrdOrKxpjtJeofe/lDUvQD/Uhgp577MmwWQ kR6nS3Mly0LqyrhHUlvweeyb6jR+zw8= =qt/e -----END PGP SIGNATURE----- --i5c56aqsedye5nda--