From: Rob Herring <robh@kernel.org>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: linux-mtd@lists.infradead.org,
Miquel Raynal <miquel.raynal@bootlin.com>,
Boris Brezillon <bbrezillon@kernel.org>,
devicetree@vger.kernel.org,
Brian Norris <computersforpeace@gmail.com>,
linux-kernel@vger.kernel.org, Marek Vasut <marek.vasut@gmail.com>,
Richard Weinberger <richard@nod.at>,
David Woodhouse <dwmw2@infradead.org>,
Mark Rutland <mark.rutland@arm.com>
Subject: Re: [PATCH v2 08/10] mtd: rawnand: denali: decouple controller and NAND chips
Date: Mon, 18 Feb 2019 14:01:19 -0600 [thread overview]
Message-ID: <20190218200119.GA27213@bogus> (raw)
In-Reply-To: <1549955582-30346-9-git-send-email-yamada.masahiro@socionext.com>
On Tue, Feb 12, 2019 at 04:13:00PM +0900, Masahiro Yamada wrote:
> Currently, this driver sticks to the legacy NAND model because it was
> upstreamed before commit 2d472aba15ff ("mtd: nand: document the NAND
> controller/NAND chip DT representation"). However, relying on the
> dummy_controller is already deprecated.
>
> Switch over to the new controller/chip representation.
>
> The struct denali_nand_info has been split into denali_controller
> and denali_chip, to contain the controller data, per-chip data,
> respectively.
>
> One problem is, this commit changes the DT binding. So, as always,
> the backward compatibility must be taken into consideration.
>
> In the new binding, the controller node expects
>
> #address-cells = <1>;
> #size-cells = <0>;
>
> ... since the child nodes represent NAND chips.
>
> In the old binding, the controller node may have subnodes, but they
> are MTD partitions.
>
> The denali_dt_is_legacy_binding() exploits it to distinguish old/new
> platforms.
>
> Going forward, the old binding is only allowed for existing DT files.
> I updated the binding document.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
> Changes in v2: None
>
> .../devicetree/bindings/mtd/denali-nand.txt | 39 +-
Acked-by: Rob Herring <robh@kernel.org>
> drivers/mtd/nand/raw/denali.c | 453 ++++++++++++---------
> drivers/mtd/nand/raw/denali.h | 117 +++++-
> drivers/mtd/nand/raw/denali_dt.c | 98 ++++-
> drivers/mtd/nand/raw/denali_pci.c | 30 +-
> 5 files changed, 500 insertions(+), 237 deletions(-)
prev parent reply other threads:[~2019-02-18 20:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-12 7:12 [PATCH v2 00/10] mtd: rawnand: denali: exec_op(), controller/chip separation, and cleanups Masahiro Yamada
2019-02-12 7:13 ` [PATCH v2 08/10] mtd: rawnand: denali: decouple controller and NAND chips Masahiro Yamada
2019-02-18 20:01 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190218200119.GA27213@bogus \
--to=robh@kernel.org \
--cc=bbrezillon@kernel.org \
--cc=computersforpeace@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=mark.rutland@arm.com \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).