From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vinod Koul Subject: Re: [PATCH v10 1/3] dmaengine: 8250_mtk_dma: add MediaTek uart DMA support Date: Tue, 19 Feb 2019 17:44:20 +0530 Message-ID: <20190219121420.GZ21884@vkoul-mobl> References: <1547781016-890-1-git-send-email-long.cheng@mediatek.com> <1547781016-890-2-git-send-email-long.cheng@mediatek.com> <20190204072154.GJ4296@vkoul-mobl> <1550112296.7678.5.camel@mhfsdcap03> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1550112296.7678.5.camel@mhfsdcap03> Sender: linux-kernel-owner@vger.kernel.org To: Long Cheng Cc: Randy Dunlap , Rob Herring , Mark Rutland , Ryder Lee , Sean Wang , Nicolas Boichat , Matthias Brugger , Dan Williams , Greg Kroah-Hartman , Jiri Slaby , Sean Wang , dmaengine@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, srv_heupstream@mediatek.com, Yingjoe Chen , YT Shen , Zhenbao Liu List-Id: devicetree@vger.kernel.org On 14-02-19, 10:44, Long Cheng wrote: > On Mon, 2019-02-04 at 12:51 +0530, Vinod Koul wrote: > > > +static int mtk_uart_apdma_device_pause(struct dma_chan *chan) > > > +{ > > > + /* just for check caps pass */ > > > + return 0; > > > +} > > > > please remove, this is not a mandatory fn > > Can't remove it. Before the mail, i had explained it. in 8250 uart > framework, will check the function.. I think you should fix the 8250 uart to handle driver not having a pause. Keeping a dummy pause is just wrong and sets wrong expectations for uart.. -- ~Vinod