From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH v5 05/10] dt-bindings: irqchip: Introduce TISCI Interrupt router bindings Date: Tue, 19 Feb 2019 09:11:04 -0800 Message-ID: <20190219171104.GM15711@atomide.com> References: <20190214154100.GB5720@atomide.com> <20190214174612.GF5720@atomide.com> <171e8597-2156-747d-d024-7b4bfc6f9186@ti.com> <20190215161629.GK5720@atomide.com> <2369739e-3bc8-257a-99e0-db2951c6777d@ti.com> <20190218143245.GC15711@atomide.com> <84b3ec21-9ce9-b9a8-80a9-75001db43a90@ti.com> <20190219153537.GJ15711@atomide.com> <6aa37276-0833-fdf5-575b-c3ca14f776a6@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <6aa37276-0833-fdf5-575b-c3ca14f776a6@ti.com> Sender: linux-kernel-owner@vger.kernel.org To: Lokesh Vutla Cc: marc.zyngier@arm.com, Nishanth Menon , Santosh Shilimkar , Rob Herring , tglx@linutronix.de, jason@lakedaemon.net, Linux ARM Mailing List , linux-kernel@vger.kernel.org, Device Tree Mailing List , Sekhar Nori , Tero Kristo , Peter Ujfalusi List-Id: devicetree@vger.kernel.org * Lokesh Vutla [190219 16:19]: > yes. How different is this from any of the above mentioned drivers using > firmware specific ids. Like sci pm domain[1] driver utilizes the same > device id for enabling any device in the system. Similarly clock > driver[2] uses the same device ids and clock ids specified by firmware. > There are more which similarly represents firmware ids from DT. > > [1] Documentation/devicetree/bindings/soc/ti/sci-pm-domain.txt > [2] Documentation/devicetree/bindings/clock/ti,sci-clk.txt That's horrible. We really must not use any firmware invented numbers in the device as they do not describe hardware. Regards, Tony