From: Sam Ravnborg <sam@ravnborg.org>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: thierry.reding@gmail.com, airlied@linux.ie, daniel@ffwll.ch,
devicetree@vger.kernel.org, tomi.valkeinen@ti.com,
robh+dt@kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 4/4] drm/panel: Add OSD101T2587-53TS driver
Date: Wed, 20 Feb 2019 13:41:20 +0100 [thread overview]
Message-ID: <20190220124120.GB18603@ravnborg.org> (raw)
In-Reply-To: <2398a647-be4c-15e4-3e28-36382a834dce@ti.com>
Hi Peter.
Always good to see that feedback input is used.
> OK.
>
> >> +
> >> + return 0;
> >> +}
> >> +
> >> +static void osd101t2587_panel_shutdown(struct mipi_dsi_device *dsi)
> >> +{
> >> + struct osd101t2587_panel *osd101t2587 = mipi_dsi_get_drvdata(dsi);
> >> +
> > Maybe call osd101t2587_panel_unprepare() here to turn off power supply?
>
> Make sense, in this order:
> osd101t2587_panel_disable(&osd101t2587->base);
> osd101t2587_panel_unprepare(&osd101t2587->base);
>
> But should the osd101t2587_panel_remove() do the same thing? or the
> osd101t2587_panel_disable() is redundant in the osd101t2587_panel_remove()?
I do not know the details to answer this.
In other words - I do not know if we can rely on that panel->disbale is always
called when a driver is removed.
Try to read the descriptions and maybe test it.
Other drivers do as far as I recall use disable in the remove function.
Sam
next prev parent reply other threads:[~2019-02-20 12:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-15 14:03 [PATCH 0/4] drm/panel: Support for OSD101T2045-53TS and OSD101T2587-53TS Peter Ujfalusi
2019-02-15 14:03 ` [PATCH 1/4] dt-bindings: display: Add bindings for OSD101T2045-53TS Peter Ujfalusi
2019-02-15 14:03 ` [PATCH 2/4] drm/panel: simple: Add support " Peter Ujfalusi
2019-02-15 14:03 ` [PATCH 3/4] dt-bindings: display: Add bindings for OSD101T2587-53TS panel Peter Ujfalusi
2019-02-15 14:03 ` [PATCH 4/4] drm/panel: Add OSD101T2587-53TS driver Peter Ujfalusi
2019-02-15 18:07 ` Sam Ravnborg
2019-02-20 10:34 ` Peter Ujfalusi
2019-02-20 12:41 ` Sam Ravnborg [this message]
2019-02-20 10:39 ` Peter Ujfalusi
2019-02-20 11:52 ` Sam Ravnborg
2019-02-20 12:06 ` Peter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190220124120.GB18603@ravnborg.org \
--to=sam@ravnborg.org \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.ujfalusi@ti.com \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).