From: Tony Lindgren <tony@atomide.com>
To: Grygorii Strashko <grygorii.strashko@ti.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Kishon Vijay Abraham I <kishon@ti.com>,
Rob Herring <robh+dt@kernel.org>,
netdev@vger.kernel.org, Sekhar Nori <nsekhar@ti.com>,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 6/6] net: ethernet: ti: cpsw: deprecate cpsw-phy-sel driver
Date: Wed, 20 Feb 2019 08:18:09 -0800 [thread overview]
Message-ID: <20190220161809.GR15711@atomide.com> (raw)
In-Reply-To: <1550676319-6440-7-git-send-email-grygorii.strashko@ti.com>
Hi,
* Grygorii Strashko <grygorii.strashko@ti.com> [190220 15:26]:
> Deprecate cpsw-phy-sel driver as it's been replaced with new
> TI phy-gmii-sel PHY driver.
I'm not going to pick up this one, seems that Dave can merge
this later on? That is unless Dave wants to ack this one.
Regards,
Tony
> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
> ---
> drivers/net/ethernet/ti/Kconfig | 6 +++---
> drivers/net/ethernet/ti/cpsw.h | 6 ++++++
> 2 files changed, 9 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/ti/Kconfig b/drivers/net/ethernet/ti/Kconfig
> index bb126be1eb72..8b21b40a9fe5 100644
> --- a/drivers/net/ethernet/ti/Kconfig
> +++ b/drivers/net/ethernet/ti/Kconfig
> @@ -49,10 +49,11 @@ config TI_DAVINCI_CPDMA
> will be called davinci_cpdma. This is recommended.
>
> config TI_CPSW_PHY_SEL
> - bool
> + bool "TI CPSW Phy mode Selection (DEPRECATED)"
> + default n
> ---help---
> This driver supports configuring of the phy mode connected to
> - the CPSW.
> + the CPSW. DEPRECATED: use PHY_TI_GMII_SEL.
>
> config TI_CPSW_ALE
> tristate "TI CPSW ALE Support"
> @@ -64,7 +65,6 @@ config TI_CPSW
> depends on ARCH_DAVINCI || ARCH_OMAP2PLUS || COMPILE_TEST
> select TI_DAVINCI_CPDMA
> select TI_DAVINCI_MDIO
> - select TI_CPSW_PHY_SEL
> select TI_CPSW_ALE
> select MFD_SYSCON
> select REGMAP
> diff --git a/drivers/net/ethernet/ti/cpsw.h b/drivers/net/ethernet/ti/cpsw.h
> index cf111db3dc27..907e05fc22e4 100644
> --- a/drivers/net/ethernet/ti/cpsw.h
> +++ b/drivers/net/ethernet/ti/cpsw.h
> @@ -21,7 +21,13 @@
> ((mac)[2] << 16) | ((mac)[3] << 24))
> #define mac_lo(mac) (((mac)[4] << 0) | ((mac)[5] << 8))
>
> +#if IS_ENABLED(CONFIG_TI_CPSW_PHY_SEL)
> void cpsw_phy_sel(struct device *dev, phy_interface_t phy_mode, int slave);
> +#else
> +static inline
> +void cpsw_phy_sel(struct device *dev, phy_interface_t phy_mode, int slave)
> +{}
> +#endif
> int ti_cm_get_macid(struct device *dev, int slave, u8 *mac_addr);
>
> #endif /* __CPSW_H__ */
> --
> 2.17.1
>
next prev parent reply other threads:[~2019-02-20 16:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-20 15:25 [PATCH 0/6] ARM: dts: ti: cpsw: switch to phy-gmii-sel phy driver Grygorii Strashko
2019-02-20 15:25 ` [PATCH 1/6] ARM: dts: dra7: switch to use phy-gmii-sel Grygorii Strashko
2019-02-20 15:25 ` [PATCH 2/6] ARM: dts: dm814x: " Grygorii Strashko
2019-02-20 15:25 ` [PATCH 3/6] ARM: dts: am4372: " Grygorii Strashko
2019-02-20 15:25 ` [PATCH 4/6] ARM: dts: am335x: " Grygorii Strashko
2019-02-20 15:25 ` [PATCH 5/6] dt-bindings: net: ti: deprecate cpsw-phy-sel bindings Grygorii Strashko
2019-02-20 15:25 ` [PATCH 6/6] net: ethernet: ti: cpsw: deprecate cpsw-phy-sel driver Grygorii Strashko
2019-02-20 16:18 ` Tony Lindgren [this message]
2019-02-20 19:22 ` David Miller
2019-02-20 20:33 ` Tony Lindgren
2019-02-20 20:41 ` David Miller
2019-02-20 21:01 ` Tony Lindgren
2019-02-21 0:18 ` David Miller
2019-02-21 16:36 ` Tony Lindgren
2019-02-20 15:48 ` [PATCH 0/6] ARM: dts: ti: cpsw: switch to phy-gmii-sel phy driver Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190220161809.GR15711@atomide.com \
--to=tony@atomide.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=grygorii.strashko@ti.com \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).