From: Mark Brown <broonie@kernel.org>
To: Christian Hohnstaedt <Christian.Hohnstaedt@wago.com>
Cc: J Keerthy <j-keerthy@ti.com>, Liam Girdwood <lgirdwood@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Tony Lindgren <tony@atomide.com>,
devicetree@vger.kernel.org, linux-omap@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] regulator: tps65218: Add support for LS2
Date: Wed, 20 Feb 2019 16:48:51 +0000 [thread overview]
Message-ID: <20190220164851.GD9878@sirena.org.uk> (raw)
In-Reply-To: <1550650552-26013-4-git-send-email-Christian.Hohnstaedt@wago.com>
[-- Attachment #1: Type: text/plain, Size: 777 bytes --]
On Wed, Feb 20, 2019 at 09:15:52AM +0100, Christian Hohnstaedt wrote:
> + TPS65218_REGULATOR("LS2", "regulator-ls2", TPS65218_LS_2,
> + REGULATOR_CURRENT, tps65218_ls23_ops, 0, 0, 0,
> + TPS65218_REG_ENABLE2, TPS65218_ENABLE2_LS2_EN,
> + TPS65218_REG_CONFIG2, TPS65218_CONFIG2_LS2ILIM_MASK,
> + NULL, 0, 0, 0, 0, 0),
This doesn't build:
drivers/regulator/tps65218-regulator.c:309:45: error: ‘TPS65218_LS_2’ undeclared here (not in a function); did you mean ‘TPS65218_LS_3’?
TPS65218_REGULATOR("LS2", "regulator-ls2", TPS65218_LS_2,
^~~~~~~~~~~~~
drivers/regulator/tps65218-regulator.c:36:11: note: in definition of macro ‘TPS65218_REGULATOR’
.id = _id, \
^~~
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-02-20 16:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-20 8:15 [PATCH 0/3] regulator: tps65218: Fix LS3 and add LS2 Christian Hohnstaedt
2019-02-20 8:15 ` [PATCH 1/3] regulator: tps65218.c: fix LS3 issues Christian Hohnstaedt
2019-02-20 16:40 ` Mark Brown
2019-02-20 8:15 ` [PATCH 2/3] dt-bindings: regulator: Add LS2 load switch Christian Hohnstaedt
2019-02-20 8:15 ` [PATCH 3/3] regulator: tps65218: Add support for LS2 Christian Hohnstaedt
2019-02-20 16:48 ` Mark Brown [this message]
2019-02-22 8:38 ` [PATCH v2] " Christian Hohnstaedt
2019-02-22 12:19 ` Mark Brown
2019-02-25 6:41 ` [PATCH v2 0/2] regulator: tps65218: support LS2 Christian Hohnstaedt
2019-02-25 6:41 ` [PATCH v2 1/2] dt-bindings: regulator: add LS2 load switch documentation Christian Hohnstaedt
2019-02-27 23:44 ` Rob Herring
2019-02-25 6:41 ` [PATCH v2 2/2] regulator: tps65218: add support for LS2 Christian Hohnstaedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190220164851.GD9878@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Christian.Hohnstaedt@wago.com \
--cc=devicetree@vger.kernel.org \
--cc=j-keerthy@ti.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).