From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: Ludovic Barre <ludovic.Barre@st.com>
Cc: devicetree@vger.kernel.org, Ulf Hansson <ulf.hansson@linaro.org>,
Alexandre Torgue <alexandre.torgue@st.com>,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>,
srinivas.kandagatla@linaro.org,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 0/2] mmc: mmci: add quirk property to add stm32 transfer mode
Date: Thu, 21 Feb 2019 10:30:49 +0000 [thread overview]
Message-ID: <20190221103049.tspc5igoe6wmt3jd@shell.armlinux.org.uk> (raw)
In-Reply-To: <20190221102739.cc37au6elqu6gvfe@shell.armlinux.org.uk>
On Thu, Feb 21, 2019 at 10:27:39AM +0000, Russell King - ARM Linux admin wrote:
> On Thu, Feb 21, 2019 at 11:10:49AM +0100, Ludovic Barre wrote:
> > From: Ludovic Barre <ludovic.barre@st.com>
> >
> > This patch series introduces a bitmap of hardware quirks that require
> > some special action. This should reduce the number of boolean
> > into variant structure.
> > And adds quirk bit to define sdmmc specific transfer modes.
>
> Please find some other way to deal with these differences. As far as
> I'm concerned, introducing a quirk bitmask such as what was done in
> sdhci is a complete disaster and leads to long-term maintanability
> problems.
>
> We already have a way to deal with variants in mmci.
... to finish what I was saying ...
and I think that:
if (variant->blksz_datactrl16)
datactrl = variant->datactrl_dpsm_enable | (data->blksz << 16);
else if (variant->blksz_datactrl4)
datactrl = variant->datactrl_dpsm_enable | (data->blksz << 4);
else
datactrl = variant->datactrl_dpsm_enable | blksz_bits << 4;
ought to become a variant function call which returns the appropriate
datactrl value. This would shrink the amount of variant testing in this
path, and also means that going forward we aren't facing an endlessly
increasing number of tests here.
>
> >
> > Ludovic Barre (2):
> > mmc: mmci: introduce a quirks property into variant struct
> > mmc: mmci: add quirk property to add stm32 transfer mode
> >
> > drivers/mmc/host/mmci.c | 11 +++++++++++
> > drivers/mmc/host/mmci.h | 9 +++++++++
> > 2 files changed, 20 insertions(+)
> >
> > --
> > 2.7.4
> >
> >
> > _______________________________________________
> > linux-arm-kernel mailing list
> > linux-arm-kernel@lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> >
>
> --
> RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
> FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
> According to speedtest.net: 11.9Mbps down 500kbps up
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up
next prev parent reply other threads:[~2019-02-21 10:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-21 10:10 [PATCH 0/2] mmc: mmci: add quirk property to add stm32 transfer mode Ludovic Barre
2019-02-21 10:10 ` [PATCH 1/2] mmc: mmci: introduce a quirks property into variant struct Ludovic Barre
2019-02-21 10:10 ` [PATCH 2/2] mmc: mmci: add quirk property to add stm32 transfer mode Ludovic Barre
2019-02-21 10:27 ` [PATCH 0/2] " Russell King - ARM Linux admin
2019-02-21 10:30 ` Russell King - ARM Linux admin [this message]
2019-02-21 13:38 ` Ludovic BARRE
2019-02-21 14:03 ` Russell King - ARM Linux admin
2019-02-25 10:48 ` Ludovic BARRE
2019-02-27 9:11 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190221103049.tspc5igoe6wmt3jd@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=alexandre.torgue@st.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=ludovic.Barre@st.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).