From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Mark Rutland <mark.rutland@arm.com>, Andrew Lunn <andrew@lunn.ch>,
Jason Cooper <jason@lakedaemon.net>,
devicetree@vger.kernel.org, Marc Zyngier <marc.zyngier@arm.com>,
Gregory Clement <gregory.clement@bootlin.com>,
Maxime Chevallier <maxime.chevallier@bootlin.com>,
Nadav Haklai <nadavh@marvell.com>,
linux-ide@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Antoine Tenart <antoine.tenart@bootlin.com>,
Jens Axboe <axboe@kernel.dk>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Thomas Gleixner <tglx@linutronix.de>,
linux-arm-kernel@lists.infradead.org,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Subject: Re: [PATCH 2/5] ata: libahci_platform: Support per-port interrupts
Date: Fri, 22 Feb 2019 16:31:14 +0100 [thread overview]
Message-ID: <20190222163114.0f4488fe@xps13> (raw)
In-Reply-To: <5040d4cf-7da1-eefa-a8a3-bc4054d528da@redhat.com>
Hi Hans,
Hans de Goede <hdegoede@redhat.com> wrote on Fri, 22 Feb 2019 16:26:01
+0100:
> Hi,
>
> On 2/22/19 3:53 PM, Miquel Raynal wrote:
> > Right now the ATA core only allows IPs to use a single interrupt. Some
> > of them (for instance the Armada-CP110 one) actually has one interrupt
> > per port. Add some logic to support such situation.
> >
> > We consider that either there is one single interrupt declared in the
> > main IP node, or there are per-port interrupts, each of them being
> > declared in the port sub-nodes.
> >
> > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> > ---
> > drivers/ata/acard-ahci.c | 2 +-
> > drivers/ata/ahci.c | 2 +-
> > drivers/ata/ahci.h | 3 +-
> > drivers/ata/libahci.c | 2 +-
> > drivers/ata/libahci_platform.c | 66 ++++++++++++++++++++++++++++------
> > drivers/ata/sata_highbank.c | 2 +-
> > 6 files changed, 61 insertions(+), 16 deletions(-)
> >
> > diff --git a/drivers/ata/acard-ahci.c b/drivers/ata/acard-ahci.c
> > index 583e366be7e2..9414b81e994c 100644
> > --- a/drivers/ata/acard-ahci.c
> > +++ b/drivers/ata/acard-ahci.c
> > @@ -434,7 +434,7 @@ static int acard_ahci_init_one(struct pci_dev *pdev, const struct pci_device_id
> > if (!hpriv)
> > return -ENOMEM;
> > > - hpriv->irq = pdev->irq;
> > + hpriv->irqs[0] = pdev->irq;
> > hpriv->flags |= (unsigned long)pi.private_data;
> >
> What code-path is going to alloc hpriv->irqs for drivers using this code-path
> which are not using libahci_platform .c ?
I don't understand the question (or the remark behind the question),
can you explain a little bit more what you have in mind?
Thanks,
Miquèl
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-02-22 15:31 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-22 14:53 [PATCH 0/5] Enable per-port SATA interrupts and drop an hack in the IRQ subsystem Miquel Raynal
2019-02-22 14:53 ` [PATCH 1/5] ata: libahci: Ensure the host interrupt status bits are cleared Miquel Raynal
2019-02-22 14:53 ` [PATCH 2/5] ata: libahci_platform: Support per-port interrupts Miquel Raynal
2019-02-22 15:26 ` Hans de Goede
2019-02-22 15:31 ` Miquel Raynal [this message]
2019-02-22 15:52 ` Hans de Goede
2019-02-22 16:03 ` Miquel Raynal
2019-02-22 16:10 ` Hans de Goede
2019-02-25 18:08 ` Jens Axboe
2019-02-22 16:41 ` Marc Zyngier
2019-02-22 14:53 ` [PATCH 3/5] irqchip/irq-mvebu-icu: Move the double SATA ports interrupt hack Miquel Raynal
2019-02-23 19:19 ` Marc Zyngier
2019-02-25 15:22 ` Miquel Raynal
2019-02-22 14:53 ` [PATCH 4/5] arm64: dts: marvell: armada-8040-clearfog: Drop non-existent SATA port Miquel Raynal
2019-02-24 5:29 ` Baruch Siach
2019-02-25 10:58 ` Miquel Raynal
2019-02-25 12:15 ` Baruch Siach
2019-02-25 13:05 ` Russell King - ARM Linux admin
2019-02-27 5:16 ` Baruch Siach
2019-02-22 14:53 ` [PATCH 5/5] arm64: dts: marvell: armada-cp110: Switch to per-port SATA interrupts Miquel Raynal
2019-02-22 15:13 ` Russell King - ARM Linux admin
2019-02-22 15:29 ` Miquel Raynal
2019-02-23 19:21 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190222163114.0f4488fe@xps13 \
--to=miquel.raynal@bootlin.com \
--cc=andrew@lunn.ch \
--cc=antoine.tenart@bootlin.com \
--cc=axboe@kernel.dk \
--cc=devicetree@vger.kernel.org \
--cc=gregory.clement@bootlin.com \
--cc=hdegoede@redhat.com \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-ide@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=mark.rutland@arm.com \
--cc=maxime.chevallier@bootlin.com \
--cc=nadavh@marvell.com \
--cc=robh+dt@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=tglx@linutronix.de \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).