From: Rob Herring <robh@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Ran Wang <ran.wang_1@nxp.com>
Subject: Re: [PATCH v2 1/2] usb: dwc3: Add avoiding vbus glitch happen during xhci reset
Date: Fri, 22 Feb 2019 14:34:59 -0600 [thread overview]
Message-ID: <20190222203459.GA16999@bogus> (raw)
In-Reply-To: <20190219072358.43493-1-ran.wang_1@nxp.com>
On Tue, 19 Feb 2019 07:23:14 +0000, Ran Wang wrote:
> When DWC3 is set to host mode by programming register DWC3_GCTL, VBUS
> (or its control signal) will turn on immediately on related Root Hub
> ports. Then the VBUS will be de-asserted for a little while during xhci
> reset (conducted by xhci driver) for a little while and back to normal.
>
> This VBUS glitch might cause some USB devices emuration fail if kernel
> boot with them connected. One SW workaround which can fix this is to
> program all PORTSC[PP] to 0 to turn off VBUS immediately after setting
> host mode in DWC3 driver(per signal measurement result, it will be too
> late to do it in xhci-plat.c or xhci.c).
>
> Signed-off-by: Ran Wang <ran.wang_1@nxp.com>
> ---
> Changes in v2:
> - Correct typos
> - Shorten the name to snps,host-vbus-glitches
>
> Documentation/devicetree/bindings/usb/dwc3.txt | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
prev parent reply other threads:[~2019-02-22 20:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-19 7:23 [PATCH v2 1/2] usb: dwc3: Add avoiding vbus glitch happen during xhci reset Ran Wang
2019-02-19 7:23 ` [PATCH v2 2/2] usb: dwc3: Add workaround for host mode VBUS glitch when boot Ran Wang
2019-02-25 21:28 ` Yang Li
2019-02-26 5:42 ` Ran Wang
2019-02-22 20:34 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190222203459.GA16999@bogus \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=ran.wang_1@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).