From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH 1/2] dt-bindings: power: supply: gpio-charger: Add status-gpios property Date: Mon, 25 Feb 2019 15:53:17 -0600 Message-ID: <20190225215316.GA10117@bogus> References: <20190205190316.19296-1-contact@artur-rojek.eu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20190205190316.19296-1-contact@artur-rojek.eu> Sender: linux-kernel-owner@vger.kernel.org To: Artur Rojek Cc: Sebastian Reichel , Mark Rutland , linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Paul Cercueil List-Id: devicetree@vger.kernel.org On Tue, Feb 05, 2019 at 08:03:15PM +0100, Artur Rojek wrote: > Add documentation for the "status-gpios" property. > > Signed-off-by: Artur Rojek > --- > .../devicetree/bindings/power/supply/gpio-charger.txt | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/power/supply/gpio-charger.txt b/Documentation/devicetree/bindings/power/supply/gpio-charger.txt > index adbb5dc5b6e9..b98a05a4973c 100644 > --- a/Documentation/devicetree/bindings/power/supply/gpio-charger.txt > +++ b/Documentation/devicetree/bindings/power/supply/gpio-charger.txt > @@ -14,12 +14,16 @@ Required properties : > usb-cdp (USB charging downstream port) > usb-aca (USB accessory charger adapter) > > +Optional properties: > + - status-gpios: GPIO indicating the charger status So when it is asserted it has 'status'? What does status mean? > + > Example: > > usb_charger: charger { > compatible = "gpio-charger"; > charger-type = "usb-sdp"; > gpios = <&gpf0 2 0 0 0>; > + status-gpios = <&gpf0 3 0 0 0>; Humm, not sure what the thinking for 'gpios' was, but it's wrong and you just copied it. If we follow the normal cell encoding with 2 cells, this means the property takes 3 gpios (though the last 2 are marked not present with 0). Rob