From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Subject: Re: [PATCH v1 2/3] spi: pxa2xx: Introduce dma-burst-sz property support Date: Tue, 26 Feb 2019 15:02:05 +0200 Message-ID: <20190226130205.GX9224@smile.fi.intel.com> References: <20190226092441.49198-1-andriy.shevchenko@linux.intel.com> <20190226092441.49198-2-andriy.shevchenko@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Jarkko Nikula Cc: Mark Rutland , devicetree@vger.kernel.org, Mark Brown , Haojian Zhuang , linux-spi@vger.kernel.org, Rob Herring , linux-arm-kernel@lists.infradead.org, Robert Jarzmik , Daniel Mack List-Id: devicetree@vger.kernel.org On Tue, Feb 26, 2019 at 01:46:49PM +0200, Jarkko Nikula wrote: > On 2/26/19 11:24 AM, Andy Shevchenko wrote: > > Some masters may have different DMA burst size than hard coded default. > > In such case respect the value given by dma-burst-size property. > > > > Signed-off-by: Andy Shevchenko > > --- > > drivers/spi/spi-pxa2xx-dma.c | 4 +++- > > drivers/spi/spi-pxa2xx-pci.c | 8 +++++++- > > drivers/spi/spi-pxa2xx.c | 5 ++++- > > include/linux/spi/pxa2xx_spi.h | 1 + > > 4 files changed, 15 insertions(+), 3 deletions(-) > ... > > @@ -1566,9 +1568,10 @@ pxa2xx_spi_init_pdata(struct platform_device *pdev) > > ssp->pdev = pdev; > > ssp->port_id = pxa2xx_spi_get_port_id(adev); > > - pdata->is_slave = of_property_read_bool(pdev->dev.of_node, "spi-slave"); > > + pdata->is_slave = device_property_read_bool(dev, "spi-slave"); > > Unrelated change. Not sure is it worth of its own patch. Fixed in v2. -- With Best Regards, Andy Shevchenko