From: Jonathan Cameron <jic23@kernel.org>
To: Robert Yang <decatf@gmail.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] dt-bindings: iio: accel: kxcjk1013: Add device tree binding documentation
Date: Sat, 2 Mar 2019 18:56:33 +0000 [thread overview]
Message-ID: <20190302185633.022f35af@archlinux> (raw)
In-Reply-To: <20190228201811.7582-3-decatf@gmail.com>
On Thu, 28 Feb 2019 15:18:10 -0500
Robert Yang <decatf@gmail.com> wrote:
> Document device tree bindings for Kionix KXCJK-1013 Accelerometer driver.
>
> Signed-off-by: Robert Yang <decatf@gmail.com>
Hi Robert,
Thanks for this. One comment inline.
Jonathan
> ---
> .../bindings/iio/accel/kionix,kxcjk1013.txt | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/accel/kionix,kxcjk1013.txt
>
> diff --git a/Documentation/devicetree/bindings/iio/accel/kionix,kxcjk1013.txt b/Documentation/devicetree/bindings/iio/accel/kionix,kxcjk1013.txt
> new file mode 100644
> index 000000000000..521c53799bc5
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/accel/kionix,kxcjk1013.txt
> @@ -0,0 +1,18 @@
> +Kionix KXCJK-1013 Accelerometer device tree bindings
> +
> +Required properties:
> +
> +- compatible: Must be one of:
> + "kionix,kxcjk1013"
> + "kionix,kxcj91008"
> + "kionix,kxtj21009"
> + "kionix,kxtf9"
> + "kionix,SMO8500"
This looks like an ACPI binding rather than a device name. So
I'd drop this last one.
> + - reg: i2c slave address
> +
> +Example:
> +
> +kxtf9@f {
> + compatible = "kionix,kxtf9";
> + reg = <0x0F>;
> +};
next prev parent reply other threads:[~2019-03-02 18:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-28 20:18 [PATCH 0/3] Add device tree support for kxcjk1013 accelerometer Robert Yang
2019-02-28 20:18 ` [PATCH 1/3] dt-bindings: Add vendor prefix for Kionix, Inc Robert Yang
2019-02-28 20:18 ` [PATCH 2/3] dt-bindings: iio: accel: kxcjk1013: Add device tree binding documentation Robert Yang
2019-03-02 18:56 ` Jonathan Cameron [this message]
2019-02-28 20:18 ` [PATCH 3/3] iio: accel: kxcjk1013: Add device tree support Robert Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190302185633.022f35af@archlinux \
--to=jic23@kernel.org \
--cc=decatf@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).