From mboxrd@z Thu Jan 1 00:00:00 1970 From: Renato Lui Geh Subject: Re: [PATCH v4 4/9] staging:iio:ad7780: add chip ID values and mask Date: Sun, 3 Mar 2019 11:01:09 -0300 Message-ID: <20190303140107.ljjo3flatwmd44ya@renatolg> References: <90c573cd53bb54d49de6ac270bcff66880ccfeb5.1551358569.git.renatogeh@gmail.com> <190e26b19b8ed6559b92d3a000d852bbb0099a52.camel@analog.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <190e26b19b8ed6559b92d3a000d852bbb0099a52.camel@analog.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" To: "Ardelean, Alexandru" Cc: "mark.rutland@arm.com" , "devel@driverdev.osuosl.org" , "lars@metafoo.de" , "Hennerich, Michael" , "devicetree@vger.kernel.org" , "linux-iio@vger.kernel.org" , "gregkh@linuxfoundation.org" , "linux-kernel@vger.kernel.org" , "kernel-usp@googlegroups.com" , "robh+dt@kernel.org" , "giuliano.belinassi@usp.br" , "pmeerw@pmeerw.net" , "knaack.h@gmx.de" , "renatogeh@gmail.com" , "Popa, Stefan Serban" , "jic23@kernel.org" List-Id: devicetree@vger.kernel.org On 03/01, Ardelean, Alexandru wrote: >On Thu, 2019-02-28 at 11:24 -0300, Renato Lui Geh wrote: >> >> >> The ad7780 supports both the ad778x and ad717x families. Each chip has >> a corresponding ID. This patch provides a mask for extracting ID values >> from the status bits and also macros for the correct values for the >> ad7170, ad7171, ad7780 and ad7781. >> >> Signed-off-by: Renato Lui Geh >> --- >> drivers/staging/iio/adc/ad7780.c | 8 ++++++-- >> 1 file changed, 6 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/staging/iio/adc/ad7780.c >> b/drivers/staging/iio/adc/ad7780.c >> index 56c49e28f432..ad7617a3a141 100644 >> --- a/drivers/staging/iio/adc/ad7780.c >> +++ b/drivers/staging/iio/adc/ad7780.c >> @@ -26,10 +26,14 @@ >> #define AD7780_RDY BIT(7) >> #define AD7780_FILTER BIT(6) >> #define AD7780_ERR BIT(5) >> -#define AD7780_ID1 BIT(4) >> -#define AD7780_ID0 BIT(3) >> #define AD7780_GAIN BIT(2) >> >> +#define AD7170_ID 0 >> +#define AD7171_ID 1 >> +#define AD7780_ID 1 >> +#define AD7781_ID 0 >> + >> +#define AD7780_ID_MASK (BIT(3) | BIT(4)) > >This also doesn't have any functionality change. >The AD7170_ID, AD7171_ID, AD7780_ID & AD7781_ID IDs are also unused (maybe >in a later patch they are ?). They aren't. I added them following a previous review suggestion. Should I remove them? > >I would also leave the AD7780_ID1 & AD7780_ID0 definitions in place, since >they're easier matched with the datasheet. > >> >> #define AD7780_PATTERN_GOOD 1 >> #define AD7780_PATTERN_MASK GENMASK(1, 0) >> -- >> 2.21.0 >>