From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jonathan Cameron Subject: Re: [PATCH v2 03/10] iio: accel: bmc150: add mount matrix support Date: Sun, 3 Mar 2019 15:20:10 +0000 Message-ID: <20190303152010.6d223cba@archlinux> References: <5d256b403997704072ea5f5889a63adfe67b3a86.1550768574.git.hns@goldelico.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <5d256b403997704072ea5f5889a63adfe67b3a86.1550768574.git.hns@goldelico.com> Sender: linux-kernel-owner@vger.kernel.org To: "H. Nikolaus Schaller" Cc: Linus Walleij , Rob Herring , Mark Rutland , Andy Shevchenko , Charles Keepax , Song Qiang , Jean-Baptiste Maneyrol , Martin Kelly , Jonathan Marek , Brian Masney , Stephan Gerhold , letux-kernel@openphoenux.org, Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: devicetree@vger.kernel.org On Thu, 21 Feb 2019 18:02:48 +0100 "H. Nikolaus Schaller" wrote: > This patch allows to read a mount-matrix device tree > property and report to user-space or in-kernel iio > clients. > > Signed-off-by: H. Nikolaus Schaller Applied. Thanks, Jonathan > --- > drivers/iio/accel/bmc150-accel-core.c | 21 +++++++++++++++++++++ > 1 file changed, 21 insertions(+) > > diff --git a/drivers/iio/accel/bmc150-accel-core.c b/drivers/iio/accel/bmc150-accel-core.c > index 383c802eb5b8..b4e2d9b04e1d 100644 > --- a/drivers/iio/accel/bmc150-accel-core.c > +++ b/drivers/iio/accel/bmc150-accel-core.c > @@ -204,6 +204,7 @@ struct bmc150_accel_data { > int ev_enable_state; > int64_t timestamp, old_timestamp; /* Only used in hw fifo mode. */ > const struct bmc150_accel_chip_info *chip_info; > + struct iio_mount_matrix orientation; > }; > > static const struct { > @@ -796,6 +797,20 @@ static ssize_t bmc150_accel_get_fifo_state(struct device *dev, > return sprintf(buf, "%d\n", state); > } > > +static const struct iio_mount_matrix * > +bmc150_accel_get_mount_matrix(const struct iio_dev *indio_dev, > + const struct iio_chan_spec *chan) > +{ > + struct bmc150_accel_data *data = iio_priv(indio_dev); > + > + return &data->orientation; > +} > + > +static const struct iio_chan_spec_ext_info bmc150_accel_ext_info[] = { > + IIO_MOUNT_MATRIX(IIO_SHARED_BY_DIR, bmc150_accel_get_mount_matrix), > + { } > +}; > + > static IIO_CONST_ATTR(hwfifo_watermark_min, "1"); > static IIO_CONST_ATTR(hwfifo_watermark_max, > __stringify(BMC150_ACCEL_FIFO_LENGTH)); > @@ -978,6 +993,7 @@ static const struct iio_event_spec bmc150_accel_event = { > .shift = 16 - (bits), \ > .endianness = IIO_LE, \ > }, \ > + .ext_info = bmc150_accel_ext_info, \ > .event_spec = &bmc150_accel_event, \ > .num_event_specs = 1 \ > } > @@ -1555,6 +1571,11 @@ int bmc150_accel_core_probe(struct device *dev, struct regmap *regmap, int irq, > > data->regmap = regmap; > > + ret = iio_read_mount_matrix(dev, "mount-matrix", > + &data->orientation); > + if (ret) > + return ret; > + > ret = bmc150_accel_chip_init(data); > if (ret < 0) > return ret;