[PATCH v3 bus+gpio 2/5] dt-bindings: bus: Document moxtet bus binding

[PATCH v3 bus+gpio 2/5] dt-bindings: bus: Document moxtet bus binding

[Marek Behún]

This adds device tree binding documentation for the Moxtet bus, a bus
via which the different modules connected to the Turris Mox router can
be configured.

Signed-off-by: Marek Behún <marek.behun@nic.cz>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: devicetree@vger.kernel.org
---
 .../devicetree/bindings/bus/moxtet.txt        | 36 +++++++++++++++++++
 1 file changed, 36 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/bus/moxtet.txt

diff --git a/Documentation/devicetree/bindings/bus/moxtet.txt b/Documentation/devicetree/bindings/bus/moxtet.txt
new file mode 100644
index 000000000000..2bb998cbd3ad
--- /dev/null
+++ b/Documentation/devicetree/bindings/bus/moxtet.txt
@@ -0,0 +1,36 @@
+Turris Mox module configuration bus (over SPI)
+
+Required properties:
+ - compatible		: Should be "cznic,moxtet".
+ - #address-cells	: Has to be 1
+ - #size-cells		: Has to be 0
+ - spi-cpol		: Required inverted clock polarity
+ - spi-cpha		: Required shifted clock phase
+For other required and optional properties of SPI slave nodes please refer to
+../spi/spi-bus.txt.
+
+Required properties of subnodes:
+ - reg			: Should be position on the Moxtet bus
+
+The driver finds the devices connected to the bus by itself, but it may be
+needed to reference some of them from other parts of the device tree. In that
+case the devices can be defined as subnodes of the moxtet node.
+
+Example:
+
+	moxtet@1 {
+		#address-cells = <1>;
+		#size-cells = <0>;
+		compatible = "cznic,moxtet";
+		reg = <1>;
+		spi-max-frequency = <10000000>;
+		spi-cpol;
+		spi-cpha;
+
+		moxtet_sfp: gpio@0 {
+			compatible = "cznic,moxtet-sfp";
+			gpio-controller;
+			#gpio-cells = <2>;
+			reg = <0>;
+		}
+	};
-- 
2.19.2

[PATCH v3 bus+gpio 5/5] dt-bindings: gpio: Document GPIOs via Moxtet bus

[Marek Behún]

This patch adds documentation of the device tree bindings for GPIOs
on the devices connected via Moxtet bus.

Signed-off-by: Marek Behún <marek.behun@nic.cz>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: devicetree@vger.kernel.org
---
 .../devicetree/bindings/gpio/gpio-moxtet.txt   | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/gpio/gpio-moxtet.txt

diff --git a/Documentation/devicetree/bindings/gpio/gpio-moxtet.txt b/Documentation/devicetree/bindings/gpio/gpio-moxtet.txt
new file mode 100644
index 000000000000..410759de9f09
--- /dev/null
+++ b/Documentation/devicetree/bindings/gpio/gpio-moxtet.txt
@@ -0,0 +1,18 @@
+Turris Mox Moxtet GPIO expander via Moxtet bus
+
+Required properties:
+ - compatible		: Should be "cznic,moxtet-gpio".
+ - gpio-controller	: Marks the device node as a GPIO controller.
+ - #gpio-cells		: Should be two. For consumer use see gpio.txt.
+
+Other properties are required for a Moxtet bus device, please refer to
+Documentation/devicetree/bindings/bus/moxtet.txt.
+
+Example:
+
+	moxtet_sfp: gpio@0 {
+		compatible = "cznic,moxtet-gpio";
+		gpio-controller;
+		#gpio-cells = <2>;
+		reg = <0>;
+	}
-- 
2.19.2

Re: [PATCH v3 bus+gpio 5/5] dt-bindings: gpio: Document GPIOs via Moxtet bus

[Linus Walleij]

On Fri, Mar 1, 2019 at 4:59 AM Marek Behún <marek.behun@nic.cz> wrote:

> This patch adds documentation of the device tree bindings for GPIOs
> on the devices connected via Moxtet bus.
>
> Signed-off-by: Marek Behún <marek.behun@nic.cz>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: devicetree@vger.kernel.org

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

> +               compatible = "cznic,moxtet-gpio";

Is cznic registered in
Documentation/devicetree/bindings/vendor-prefixes.txt?

Yours,
Linus Walleij

Re: [PATCH v3 bus+gpio 5/5] dt-bindings: gpio: Document GPIOs via Moxtet bus

[Marek Behun]

On Fri, 1 Mar 2019 15:36:09 +0100
Linus Walleij <linus.walleij@linaro.org> wrote:

> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> 
> > +               compatible = "cznic,moxtet-gpio";  
> 
> Is cznic registered in
> Documentation/devicetree/bindings/vendor-prefixes.txt?

Yes, it is registered.
Thank you for the review.
Marek

Re: [PATCH v3 bus+gpio 5/5] dt-bindings: gpio: Document GPIOs via Moxtet bus

[Marek Behun]

Hi Linus,

do you know who is responsible for merging into drivers/bus?

I have received reviews for this and for previous versions only from
you and Rob.

Also, please do not merge yet. I have prepared a fourth version with
debugging over debugfs, fixed some checkpatch issues, and most
importantnly added interrupt reading support from moxtet.

I will send after proper testing is done for this new version.

Marek

On Fri, 1 Mar 2019 15:36:09 +0100
Linus Walleij <linus.walleij@linaro.org> wrote:

> On Fri, Mar 1, 2019 at 4:59 AM Marek Behún <marek.behun@nic.cz> wrote:
> 
> > This patch adds documentation of the device tree bindings for GPIOs
> > on the devices connected via Moxtet bus.
> >
> > Signed-off-by: Marek Behún <marek.behun@nic.cz>
> > Cc: Rob Herring <robh+dt@kernel.org>
> > Cc: devicetree@vger.kernel.org  
> 
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> 
> > +               compatible = "cznic,moxtet-gpio";  
> 
> Is cznic registered in
> Documentation/devicetree/bindings/vendor-prefixes.txt?
> 
> Yours,
> Linus Walleij

Re: [PATCH v3 bus+gpio 5/5] dt-bindings: gpio: Document GPIOs via Moxtet bus

[Linus Walleij]

On Mon, Mar 4, 2019 at 12:17 AM Marek Behun <marek.behun@nic.cz> wrote:

> do you know who is responsible for merging into drivers/bus?

Usually the ARM SoC maintainers arm@kernel.org merge drivers
there. You should just send them a pull request and explain the
situation I think. Else they know who should deal with it.

Yours,
Linus Walleij