From mboxrd@z Thu Jan 1 00:00:00 1970 From: Miquel Raynal Subject: Re: [PATCH v4 1/9] dt-bindings: mtd: ingenic: Add compatible strings for JZ4740 and JZ4725B Date: Mon, 4 Mar 2019 19:51:49 +0100 Message-ID: <20190304195149.7cca9c64@xps13> References: <20190209192305.4434-1-paul@crapouillou.net> <20190304104554.09be4cd4@xps13> <1551723742.4932.2@crapouillou.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Return-path: In-Reply-To: <1551723742.4932.2@crapouillou.net> Sender: linux-kernel-owner@vger.kernel.org To: Paul Cercueil Cc: David Woodhouse , Brian Norris , Boris Brezillon , Marek Vasut , Richard Weinberger , Rob Herring , Mark Rutland , Harvey Hunt , linux-mtd@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: devicetree@vger.kernel.org Hi Paul, > >> --- a/Documentation/devicetree/bindings/mtd/ingenic,jz4780-nand.txt > >> +++ b/Documentation/devicetree/bindings/mtd/ingenic,jz4780-nand.txt > >> @@ -6,7 +6,10 @@ memory-controllers/ingenic,jz4780-nemc.txt), and >> thus NAND device nodes must > >> be children of the NEMC node. > >> >> Required NAND controller device properties: > >> -- compatible: Should be set to "ingenic,jz4780-nand". > >> +- compatible: Should be one of: > >> + * ingenic,jz4740-nand > >> + * ingenic,jz4725b-nand > >> + * ingenic,jz4780-nand > > > > Wouldn't "-nand-controller" suffix be better? Of course in the driver > > you should still check for jz4780-nand. > > So I would be compatible with: > * ingenic,jz4740-nand-controller > * ingenic,jz4725b-nand-controller > * ingenic,jz4780-nand > ? >>From a driver POV I would even prefer ingenic,jz4780-nand-controller. I don't know what's best here. Maybe Boris or Rob can help? Thanks, Miquèl