From: Jonathan Cameron <jic23@kernel.org>
To: Robert Yang <decatf@gmail.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/3] iio: accel: kxcjk1013: Add device tree support
Date: Sat, 9 Mar 2019 18:16:49 +0000 [thread overview]
Message-ID: <20190309181649.228507de@archlinux> (raw)
In-Reply-To: <20190304151912.11485-4-decatf@gmail.com>
On Mon, 4 Mar 2019 10:19:12 -0500
Robert Yang <decatf@gmail.com> wrote:
> Add device tree support for kxcjk-1013 accelerometer sensors.
>
> Signed-off-by: Robert Yang <decatf@gmail.com>
One comment below.
Applied with that minor tweak to the togreg branch of iio.git
and pushed out as testing for the autobuilders to play with it.
Thanks,
Jonathan
> ---
> drivers/iio/accel/kxcjk-1013.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/drivers/iio/accel/kxcjk-1013.c b/drivers/iio/accel/kxcjk-1013.c
> index 7096e577b23f..e4cbc443e6ed 100644
> --- a/drivers/iio/accel/kxcjk-1013.c
> +++ b/drivers/iio/accel/kxcjk-1013.c
> @@ -1510,10 +1510,20 @@ static const struct i2c_device_id kxcjk1013_id[] = {
>
> MODULE_DEVICE_TABLE(i2c, kxcjk1013_id);
>
> +static const struct of_device_id kxcjk1013_of_match[] = {
> + { .compatible = "kionix,kxcjk1013", },
> + { .compatible = "kionix,kxcj91008", },
> + { .compatible = "kionix,kxtj21009", },
> + { .compatible = "kionix,kxtf9", },
> + { }
> +};
> +MODULE_DEVICE_TABLE(of, kxcjk1013_of_match);
> +
> static struct i2c_driver kxcjk1013_driver = {
> .driver = {
> .name = KXCJK1013_DRV_NAME,
> .acpi_match_table = ACPI_PTR(kx_acpi_match),
> + .of_match_table = of_match_ptr(kxcjk1013_of_match),
Sorry. I'd missed this before, but general preference is to not
use of_match_table any more because it stops people using the
somewhat odd ACPI object that lets you used dt bindings
via ACPI.
I'll drop it.
> .pm = &kxcjk1013_pm_ops,
> },
> .probe = kxcjk1013_probe,
prev parent reply other threads:[~2019-03-09 18:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-04 15:19 [PATCH v2 0/3] Add device tree support for kxcjk1013 accelerometer Robert Yang
2019-03-04 15:19 ` [PATCH v2 1/3] dt-bindings: Add vendor prefix for Kionix, Inc Robert Yang
2019-03-09 18:13 ` Jonathan Cameron
2019-03-12 18:36 ` Rob Herring
2019-03-04 15:19 ` [PATCH v2 2/3] dt-bindings: iio: accel: kxcjk1013: Add device tree binding documentation Robert Yang
2019-03-09 18:15 ` Jonathan Cameron
2019-03-12 18:36 ` Rob Herring
2019-03-04 15:19 ` [PATCH v2 3/3] iio: accel: kxcjk1013: Add device tree support Robert Yang
2019-03-09 18:16 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190309181649.228507de@archlinux \
--to=jic23@kernel.org \
--cc=decatf@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).