Re: [PATCH v3 4/7] dt-bindings: phy: Add document for phy-mtk-ufs

[Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>]

On Wed, Feb 27, 2019 at 03:23:09PM +0800, Stanley Chu wrote:
> Add UFS M-PHY node document for MediaTek SoC chips.
> 
> Signed-off-by: Stanley Chu <stanley.chu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
> ---
>  .../devicetree/bindings/phy/phy-mtk-ufs.txt   | 35 +++++++++++++++++++
>  1 file changed, 35 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/phy/phy-mtk-ufs.txt
> 
> diff --git a/Documentation/devicetree/bindings/phy/phy-mtk-ufs.txt b/Documentation/devicetree/bindings/phy/phy-mtk-ufs.txt
> new file mode 100644
> index 000000000000..5fc22c7fe0bc
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/phy/phy-mtk-ufs.txt
> @@ -0,0 +1,35 @@
> +MediaTek Universal Flash Storage (UFS) M-PHY binding
> +--------------------------------------------------------
> +
> +UFS M-PHY nodes are defined to describe on-chip UFS M-PHY hardware macro.
> +Each UFS M-PHY node should have its own node.
> +
> +To bind UFS M-PHY with UFS host controller, the controller node should
> +contain a phandle reference to UFS M-PHY node.
> +
> +Required properties for UFS M-PHY nodes:
> +- compatible         : Compatible list, contains the following controller:
> +                       "mediatek,ufs-mphy"

Needs a more specific compatible string.

> +- reg                : Address and length of the UFS M-PHY register set.
> +- #phy-cells         : This property shall be set to 0
> +- clocks             : List of phandle and clock specifier pairs.
> +- clock-names        : List of clock input name strings sorted in the same
> +                       order as the clocks property. "unipro-clk" and
> +                       "mp-clk" are mandatory.
> +
> +Example:
> +
> +	ufs_mphy: ufs_mphy@11fa0000 {

phy@...

> +		compatible = "mediatek,ufs-mphy";
> +		reg = <0 0x11fa0000 0 0xc000>;
> +		#phy-cells = <0>;
> +
> +		clocks = <&infracfg_ao INFRACFG_AO_UNIPRO_SCK_CG>,
> +			 <&infracfg_ao INFRACFG_AO_UFS_MP_SAP_BCLK_CG>;
> +		clock-names = "unipro-clk", "mp-clk";
> +	};
> +
> +	ufshci:ufshci@11270000 {
> +		...
> +		phys = <&ufs_mphy>;
> +	};
> -- 
> 2.18.0
>