* [PATCH v2 1/2] dt-bindings: rcar-csi2: List resets as a mandatory property
[not found] <20190308234722.25775-1-niklas.soderlund+renesas@ragnatech.se>
@ 2019-03-08 23:47 ` Niklas Söderlund
2019-03-11 9:09 ` Laurent Pinchart
2019-03-12 19:30 ` Rob Herring
0 siblings, 2 replies; 3+ messages in thread
From: Niklas Söderlund @ 2019-03-08 23:47 UTC (permalink / raw)
To: Laurent Pinchart, linux-media
Cc: linux-renesas-soc, Niklas Söderlund, Rob Herring, devicetree
The resets property will become mandatory to operate the device, list it
as such. All device tree source files have always included the reset
property so making it mandatory will not introduce any regressions.
While at it improve the description for the clocks property.
Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
---
Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt b/Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt
index d63275e17afdd180..9a0d0531c67df48c 100644
--- a/Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt
+++ b/Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt
@@ -18,7 +18,8 @@ Mandatory properties
- reg: the register base and size for the device registers
- interrupts: the interrupt for the device
- - clocks: reference to the parent clock
+ - clocks: A phandle + clock specifier for the module clock
+ - resets: A phandle + reset specifier for the module reset
The device node shall contain two 'port' child nodes according to the
bindings defined in Documentation/devicetree/bindings/media/
--
2.21.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: rcar-csi2: List resets as a mandatory property
2019-03-08 23:47 ` [PATCH v2 1/2] dt-bindings: rcar-csi2: List resets as a mandatory property Niklas Söderlund
@ 2019-03-11 9:09 ` Laurent Pinchart
2019-03-12 19:30 ` Rob Herring
1 sibling, 0 replies; 3+ messages in thread
From: Laurent Pinchart @ 2019-03-11 9:09 UTC (permalink / raw)
To: Niklas Söderlund
Cc: linux-media, linux-renesas-soc, Rob Herring, devicetree
Hi Niklas,
Thank you for the patch.
On Sat, Mar 09, 2019 at 12:47:21AM +0100, Niklas Söderlund wrote:
> The resets property will become mandatory to operate the device, list it
> as such. All device tree source files have always included the reset
> property so making it mandatory will not introduce any regressions.
>
> While at it improve the description for the clocks property.
>
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt b/Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt
> index d63275e17afdd180..9a0d0531c67df48c 100644
> --- a/Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt
> +++ b/Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt
> @@ -18,7 +18,8 @@ Mandatory properties
>
> - reg: the register base and size for the device registers
> - interrupts: the interrupt for the device
> - - clocks: reference to the parent clock
> + - clocks: A phandle + clock specifier for the module clock
> + - resets: A phandle + reset specifier for the module reset
>
> The device node shall contain two 'port' child nodes according to the
> bindings defined in Documentation/devicetree/bindings/media/
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: rcar-csi2: List resets as a mandatory property
2019-03-08 23:47 ` [PATCH v2 1/2] dt-bindings: rcar-csi2: List resets as a mandatory property Niklas Söderlund
2019-03-11 9:09 ` Laurent Pinchart
@ 2019-03-12 19:30 ` Rob Herring
1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring @ 2019-03-12 19:30 UTC (permalink / raw)
To: Niklas Söderlund
Cc: Laurent Pinchart, linux-media, linux-renesas-soc, devicetree
On Sat, 9 Mar 2019 00:47:21 +0100, =?UTF-8?q?Niklas=20S=C3=B6derlund?= wrote:
> The resets property will become mandatory to operate the device, list it
> as such. All device tree source files have always included the reset
> property so making it mandatory will not introduce any regressions.
>
> While at it improve the description for the clocks property.
>
> Signed-off-by: Niklas S�derlund <niklas.soderlund+renesas@ragnatech.se>
> ---
> Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-03-12 19:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20190308234722.25775-1-niklas.soderlund+renesas@ragnatech.se>
2019-03-08 23:47 ` [PATCH v2 1/2] dt-bindings: rcar-csi2: List resets as a mandatory property Niklas Söderlund
2019-03-11 9:09 ` Laurent Pinchart
2019-03-12 19:30 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).