From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Paul Cercueil <paul@crapouillou.net>
Cc: David Woodhouse <dwmw2@infradead.org>,
Brian Norris <computersforpeace@gmail.com>,
Boris Brezillon <bbrezillon@kernel.org>,
Marek Vasut <marek.vasut@gmail.com>,
Richard Weinberger <richard@nod.at>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Harvey Hunt <harveyhuntnexus@gmail.com>,
od@zcrc.me, Mathieu Malaterre <malat@debian.org>,
linux-mtd@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 09/12] mtd: rawnand: ingenic: Make use of ecc-engine property
Date: Fri, 15 Mar 2019 09:40:09 +0100 [thread overview]
Message-ID: <20190315094009.66b91ad5@xps13> (raw)
In-Reply-To: <20190313222259.28704-9-paul@crapouillou.net>
Hi Paul,
Paul Cercueil <paul@crapouillou.net> wrote on Wed, 13 Mar 2019 23:22:56
+0100:
> Use the 'ecc-engine' standard property instead of the custom
> 'ingenic,bch-controller' custom property, which is now deprecated.
>
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
> ---
>
> Notes:
> v5: New patch
>
> drivers/mtd/nand/raw/ingenic/ingenic_ecc.c | 13 ++++++++++---
> 1 file changed, 10 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/mtd/nand/raw/ingenic/ingenic_ecc.c b/drivers/mtd/nand/raw/ingenic/ingenic_ecc.c
> index d7f3a8c3abea..30436ca6628a 100644
> --- a/drivers/mtd/nand/raw/ingenic/ingenic_ecc.c
> +++ b/drivers/mtd/nand/raw/ingenic/ingenic_ecc.c
> @@ -82,9 +82,9 @@ static struct ingenic_ecc *ingenic_ecc_get(struct device_node *np)
>
> /**
> * of_ingenic_ecc_get() - get the ECC controller from a DT node
> - * @of_node: the node that contains a bch-controller property.
> + * @of_node: the node that contains a ecc-engine property.
Would "contains an ecc-engine property" be better English?
I am not sure what is the rule when it comes to plain English with
variable names. However if you agree, no need to re-send the series, I
can fix it when applying.
BTW, I added hw ECC engines support to my generic ECC engine
implementation, but migrating the whole raw NAND subsystem (using I/O
requests like in the SPI-NAND core, adding prepare/finish_io_req hooks)
is going to be much more invasive than initially expected, so I am not
sure I will finish the migration any time soon.
Thanks,
Miquèl
next prev parent reply other threads:[~2019-03-15 8:40 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-13 22:22 [PATCH v5 01/12] dt-bindings: mtd: ingenic: Add compatible strings for JZ4740 and JZ4725B Paul Cercueil
2019-03-13 22:22 ` [PATCH v5 02/12] dt-bindings: mtd: ingenic: Change 'BCH' to 'ECC' in documentation Paul Cercueil
2019-03-13 22:22 ` [PATCH v5 03/12] dt-bindings: mtd: ingenic: Use standard ecc-engine property Paul Cercueil
2019-03-15 23:25 ` Rob Herring
2019-03-13 22:22 ` [PATCH v5 04/12] mtd: rawnand: Move drivers for Ingenic SoCs to subfolder Paul Cercueil
2019-03-13 22:22 ` [PATCH v5 05/12] mtd: rawnand: ingenic: Use SPDX license notifiers Paul Cercueil
2019-03-13 22:22 ` [PATCH v5 06/12] mtd: rawnand: ingenic: Rename jz4780_nand driver to ingenic_nand Paul Cercueil
2019-03-13 22:22 ` [PATCH v5 07/12] mtd: rawnand: ingenic: Rename jz4780_bch_init to jz4780_bch_reset Paul Cercueil
2019-03-13 22:22 ` [PATCH v5 08/12] mtd: rawnand: ingenic: Separate top-level and SoC specific code Paul Cercueil
2019-03-13 22:22 ` [PATCH v5 09/12] mtd: rawnand: ingenic: Make use of ecc-engine property Paul Cercueil
2019-03-15 8:40 ` Miquel Raynal [this message]
2019-03-15 14:37 ` Paul Cercueil
2019-03-18 20:37 ` Paul Cercueil
2019-03-18 21:39 ` Miquel Raynal
2019-03-13 22:22 ` [PATCH v5 10/12] mtd: rawnand: ingenic: Add support for the JZ4740 Paul Cercueil
2019-03-13 22:22 ` [PATCH v5 11/12] mtd: rawnand: ingenic: Add support for the JZ4725B Paul Cercueil
2019-03-13 22:22 ` [PATCH v5 12/12] mtd: rawnand: ingenic: Add ooblayout for the Qi Ben Nanonote Paul Cercueil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190315094009.66b91ad5@xps13 \
--to=miquel.raynal@bootlin.com \
--cc=bbrezillon@kernel.org \
--cc=computersforpeace@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=harveyhuntnexus@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=malat@debian.org \
--cc=marek.vasut@gmail.com \
--cc=mark.rutland@arm.com \
--cc=od@zcrc.me \
--cc=paul@crapouillou.net \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).