Re: [PATCH 1/2] dt-bindings: iio: accel: add LIS2DE12 sensor device binding

[Jonathan Cameron <jic23@jic23.retrosnub.co.uk>]

On Mon, 11 Mar 2019 23:02:16 +0000
Denis CIOCCA <denis.ciocca@st.com> wrote:

> Yes, you are right Jonathan.
> 
> I saw that before but since there are already 15 sensors that are not following my initial convention anymore, I decided to let it go...Not sure I'll be able to catch all of the patches.
> But your point is actually correct. I know it's a small thing but anyway what do you thing about?
Let's do best effort on this and I'll try to be careful to catch them
as well.  We could look at deprecating the inappropriate -accel bindings
and add the version with out as well.  Lots of appropriate comments
should stop people repeating this in future.

Anyhow, for now I've just fixed this one up to drop it.

Thanks,

Jonathan

> 
> Denis
> 
> 
> -----Original Message-----
> From: Jonathan Cameron <jic23@jic23.retrosnub.co.uk> 
> Sent: Saturday, March 9, 2019 10:23 AM
> To: Denis CIOCCA <denis.ciocca@st.com>
> Cc: Robert Jones <rjones@gateworks.com>; Rob Herring <robh+dt@kernel.org>; Mark Rutland <mark.rutland@arm.com>; devicetree@vger.kernel.org; linux-iio@vger.kernel.org; Hartmut Knaack <knaack.h@gmx.de>; Lars-Peter Clausen <lars@metafoo.de>; Peter Meerwald-Stadler <pmeerw@pmeerw.net>
> Subject: Re: [PATCH 1/2] dt-bindings: iio: accel: add LIS2DE12 sensor device binding
> 
> On Sat, 9 Mar 2019 18:20:26 +0000
> Jonathan Cameron <jic23@kernel.org> wrote:
> 
> > On Sat, 9 Mar 2019 01:14:14 +0000
> > Denis CIOCCA <denis.ciocca@st.com> wrote:
> >   
> > > Acked-by: Denis Ciocca <denis.ciocca@st.com>  
> > Applied to the togreg branch of iio.git and pushed out as testing for 
> > the autobuilders to play with it.
> > 
> > Thanks
> > 
> > Jonathan  
> Actually, sorry too fast to click send!
> 
> Why the -accel postfix?
> 
> That is normally only done for devices with multiple separate sensors within them.  That isn't true as far as I can see for this one.
> 
> Jonathan
> 
> >   
> > > 
> > > Thanks,
> > > Denis
> > > 
> > > 
> > > -----Original Message-----
> > > From: linux-iio-owner@vger.kernel.org 
> > > <linux-iio-owner@vger.kernel.org> On Behalf Of Robert Jones
> > > Sent: Tuesday, March 5, 2019 12:33 PM
> > > To: Jonathan Cameron <jic23@kernel.org>; Rob Herring 
> > > <robh+dt@kernel.org>; Mark Rutland <mark.rutland@arm.com>
> > > Cc: devicetree@vger.kernel.org; linux-iio@vger.kernel.org; Hartmut 
> > > Knaack <knaack.h@gmx.de>; Lars-Peter Clausen <lars@metafoo.de>; 
> > > Peter Meerwald-Stadler <pmeerw@pmeerw.net>; Robert Jones 
> > > <rjones@gateworks.com>
> > > Subject: [PATCH 1/2] dt-bindings: iio: accel: add LIS2DE12 sensor 
> > > device binding
> > > 
> > > Signed-off-by: Robert Jones <rjones@gateworks.com>
> > > ---
> > >  Documentation/devicetree/bindings/iio/st-sensors.txt | 1 +
> > >  1 file changed, 1 insertion(+)
> > > 
> > > diff --git a/Documentation/devicetree/bindings/iio/st-sensors.txt 
> > > b/Documentation/devicetree/bindings/iio/st-sensors.txt
> > > index 52ee4ba..7f24b33 100644
> > > --- a/Documentation/devicetree/bindings/iio/st-sensors.txt
> > > +++ b/Documentation/devicetree/bindings/iio/st-sensors.txt
> > > @@ -49,6 +49,7 @@ Accelerometers:
> > >  - st,lis2dw12
> > >  - st,lis3dhh
> > >  - st,lis3de
> > > +- st,lis2de12-accel
> > >  
> > >  Gyroscopes:
> > >  - st,l3g4200d-gyro  
> >   
>