devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: Marek Vasut <marex@denx.de>
Cc: "Måns Rullgård" <mans@mansr.com>,
	"Tim Harvey" <tharvey@gateworks.com>,
	"Douglas Anderson" <dianders@chromium.org>,
	"Ulf Hansson" <ulf.hansson@linaro.org>,
	"Jaehoon Chung" <jh80.chung@samsung.com>,
	shawn.lin@rock-chips.com,
	"Adrian Hunter" <adrian.hunter@intel.com>,
	stefan@agner.ch, "Linux MMC List" <linux-mmc@vger.kernel.org>,
	"Brian Norris" <computersforpeace@gmail.com>,
	"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
	"Heiko Stuebner" <heiko@sntech.de>,
	"Jisheng Zhang" <jszhang@marvell.com>,
	linux-rockchip@lists.infradead.org,
	devicetree-spec@vger.kernel.org,
	"Mark Rutland" <mark.rutland@arm.com>,
	"open list" <linux-kernel@vger.kernel.org>,
	vbyravarasu@nvidia.com, "Lars-Peter Clausen" <lars@metafoo.de>,
	jonathanh@nvidia.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 0/4] Patches to allow consistent mmc / mmcblk numbering w/ device tree
Date: Sat, 16 Mar 2019 15:39:01 +0000	[thread overview]
Message-ID: <20190316153900.xqi55awrockovmsi@shell.armlinux.org.uk> (raw)
In-Reply-To: <1fcd4dad-1e00-67cc-ac5d-24640ae34340@denx.de>

On Sat, Mar 16, 2019 at 01:33:58PM +0100, Marek Vasut wrote:
> If you have a FS or partition table there, it does.
> If you don't, I agree ... that's a problem.

eMMC boot partitions are called mmcblkXbootY, and unless you have more
than one eMMC device on the system, they can be found either by looking
for /dev/mmcblk*boot* or by querying udev.  The advantage of using udev
is you can discover the physical device behind it by looking at DEVPATH,
ID_PATH, etc, but you may not have that installed on an embedded device.

However, as I say, just looking for /dev/mmcblk*boot* is sufficient to
find the eMMC boot partitions where there is just one eMMC device
present (which seems to be the standard setup.)

> > I don't care the slightest what the numbering is, as long as it is
> > stable.  On some hardware, with an unpatched kernel, the mmc device
> > numbering changes depending on whether or not an SD card is inserted on
> > boot.  Getting rid of that behaviour is really all I want.
> 
> Agreed, that would be an improvement.

The mmc device numbering was tied to the mmc host numbering a while back
and the order that the hosts are probed should be completely independent
of whether a card is inserted or not:

        snprintf(md->disk->disk_name, sizeof(md->disk->disk_name),
                 "mmcblk%u%s", card->host->index, subname ? subname : "");

        snprintf(rpmb_name, sizeof(rpmb_name),
                 "mmcblk%u%s", card->host->index, subname ? subname : "");

I suspect that Mans is quoting something from the dim and distant past
to confuse the issue - as shown above, it is now dependent on the host
numbering order not the order in which cards are inserted.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up

  reply	other threads:[~2019-03-16 15:39 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-29 17:32 [PATCH v2 0/4] Patches to allow consistent mmc / mmcblk numbering w/ device tree Douglas Anderson
2016-04-29 17:32 ` [PATCH v2 4/4] ARM: dts: rockchip: Add mmc aliases for rk3288 platform Douglas Anderson
     [not found] ` <1461951139-6109-1-git-send-email-dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2016-04-29 17:32   ` [PATCH v2 1/4] Documentation: mmc: Document mmc aliases Douglas Anderson
2016-04-29 18:12   ` [PATCH v2 0/4] Patches to allow consistent mmc / mmcblk numbering w/ device tree Rob Herring
     [not found]     ` <CAL_JsqKOADU1hyLj+3cHjTJ7wgkOi-z-iWvFD3Bx5dvB12j+KQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-04-29 19:31       ` Doug Anderson
     [not found]         ` <CAD=FV=XFZ+4o_QyOdkNZyZ6ZmyXNH1Fbn458oeAxAMLOB=fLkg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-04-29 19:50           ` Russell King - ARM Linux
     [not found]             ` <20160429195007.GX19428-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2016-04-29 20:02               ` Doug Anderson
2016-04-29 18:12   ` Russell King - ARM Linux
     [not found]     ` <20160429181248.GW19428-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2016-04-29 19:43       ` Doug Anderson
2016-04-29 19:57         ` Russell King - ARM Linux
     [not found]           ` <20160429195741.GY19428-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2016-04-29 20:04             ` Doug Anderson
2016-04-29 21:13               ` Russell King - ARM Linux
     [not found]                 ` <20160429211328.GZ19428-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2016-04-29 21:17                   ` Doug Anderson
2016-04-29 21:29                     ` Russell King - ARM Linux
     [not found]                       ` <20160429212920.GA19428-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2016-04-29 21:39                         ` Doug Anderson
2016-04-29 21:50                           ` Russell King - ARM Linux
2016-04-29 21:56                             ` Doug Anderson
2016-04-29 22:16                               ` Russell King - ARM Linux
2016-04-29 22:22                                 ` Doug Anderson
     [not found]                                   ` <CAD=FV=WzgGFzzpeYAPrOpMS684_G=XRoSRjTegK-vre=fX=kpw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-04-29 22:44                                     ` Russell King - ARM Linux
2016-04-29 23:01                                       ` Doug Anderson
     [not found]                                         ` <CAD=FV=U5jnJJ3v=nFGFecoKB5KGv1ufC+aKbHx2iCqBTWpDTww-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-04-29 23:58                                           ` Peter Hurley
     [not found]                                             ` <CAD=FV=V_YyfBOSs7BLkyhv=_5HBmf3djUWACbL6d-bwnrueDjA@mail.gmail.com>
     [not found]                                               ` <CAD=FV=V_YyfBOSs7BLkyhv=_5HBmf3djUWACbL6d-bwnrueDjA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-04-30  0:31                                                 ` Peter Hurley
2016-04-30  2:29                                                   ` Doug Anderson
     [not found]                                                   ` <5723FCE3.9070308-WaGBZJeGNqdsbIuE7sb01tBPR1lH4CV8@public.gmane.org>
2016-04-30  8:38                                                     ` Russell King - ARM Linux
2016-04-30 13:23                                           ` Rob Herring
2016-04-29 22:42                                 ` Javier Martinez Canillas
2016-04-30 10:48                                   ` Russell King - ARM Linux
     [not found]                                     ` <20160430104832.GJ19428-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2016-05-03 19:17                                       ` Trent Piepho
2016-05-04  7:18     ` Pavel Machek
2016-05-04 12:25       ` Rob Herring
2016-05-04 12:46         ` Pavel Machek
2019-03-05 12:39 ` Måns Rullgård
2019-03-15 21:52   ` Tim Harvey
     [not found]     ` <CAJ+vNU1PxK-B63Dc3AgzYb9POyxxoF-xPOWBEpxJ+3eVNK8xqw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2019-03-15 23:00       ` Marek Vasut
2019-03-15 23:13         ` Tim Harvey
2019-03-15 23:23         ` Doug Anderson
2019-03-16 12:22         ` Måns Rullgård
2019-03-16 12:33           ` Marek Vasut
2019-03-16 15:39             ` Russell King - ARM Linux admin [this message]
2019-03-17 15:05               ` Stefan Agner
2019-03-17 15:43                 ` Russell King - ARM Linux admin
2019-03-17 15:50                   ` Marek Vasut
2019-03-17 16:48                 ` Måns Rullgård
2019-03-17 16:59                   ` Russell King - ARM Linux admin
2019-03-27 17:37                     ` Tim Harvey
2019-03-27 20:54                       ` Russell King - ARM Linux admin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190316153900.xqi55awrockovmsi@shell.armlinux.org.uk \
    --to=linux@armlinux.org.uk \
    --cc=adrian.hunter@intel.com \
    --cc=computersforpeace@gmail.com \
    --cc=devicetree-spec@vger.kernel.org \
    --cc=dianders@chromium.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=heiko@sntech.de \
    --cc=jh80.chung@samsung.com \
    --cc=jonathanh@nvidia.com \
    --cc=jszhang@marvell.com \
    --cc=lars@metafoo.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=mans@mansr.com \
    --cc=marex@denx.de \
    --cc=mark.rutland@arm.com \
    --cc=shawn.lin@rock-chips.com \
    --cc=stefan@agner.ch \
    --cc=tharvey@gateworks.com \
    --cc=ulf.hansson@linaro.org \
    --cc=vbyravarasu@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).