* [PATCH] ARM: dts: pfla02: increase phy reset duration
@ 2019-03-04 10:49 Marco Felsch
2019-03-20 8:59 ` Shawn Guo
0 siblings, 1 reply; 4+ messages in thread
From: Marco Felsch @ 2019-03-04 10:49 UTC (permalink / raw)
To: shawnguo, linux-imx, robh+dt
Cc: devicetree, Stefan Christ, kernel, linux-arm-kernel,
Christian Hemp
Increase the reset duration to ensure correct phy functionality. The
reset duration is taken from barebox commit 52fdd510de ("ARM: dts:
pfla02: use long enough reset for ethernet phy"):
Use a longer reset time for ethernet phy Micrel KSZ9031RNX. Otherwise a
small percentage of modules have 'transmission timeouts' errors like
barebox@Phytec phyFLEX-i.MX6 Quad Carrier-Board:/ ifup eth0
warning: No MAC address set. Using random address 7e:94:4d:02:f8:f3
eth0: 1000Mbps full duplex link detected
eth0: transmission timeout
T eth0: transmission timeout
T eth0: transmission timeout
T eth0: transmission timeout
T eth0: transmission timeout
Cc: Stefan Christ <s.christ@phytec.de>
Cc: Christian Hemp <c.hemp@phytec.de>
Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
---
arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi b/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi
index 673711f445b6..7e53ac6cfa8a 100644
--- a/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi
@@ -91,6 +91,7 @@
pinctrl-0 = <&pinctrl_enet>;
phy-handle = <ðphy>;
phy-mode = "rgmii";
+ phy-reset-duration = <10>; /* in msecs */
phy-reset-gpios = <&gpio3 23 GPIO_ACTIVE_LOW>;
phy-supply = <&vdd_eth_io_reg>;
status = "disabled";
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] ARM: dts: pfla02: increase phy reset duration
2019-03-04 10:49 [PATCH] ARM: dts: pfla02: increase phy reset duration Marco Felsch
@ 2019-03-20 8:59 ` Shawn Guo
2019-03-20 10:10 ` Marco Felsch
0 siblings, 1 reply; 4+ messages in thread
From: Shawn Guo @ 2019-03-20 8:59 UTC (permalink / raw)
To: Marco Felsch
Cc: devicetree, robh+dt, linux-imx, kernel, Christian Hemp,
Stefan Christ, linux-arm-kernel
On Mon, Mar 04, 2019 at 11:49:40AM +0100, Marco Felsch wrote:
> Increase the reset duration to ensure correct phy functionality. The
> reset duration is taken from barebox commit 52fdd510de ("ARM: dts:
> pfla02: use long enough reset for ethernet phy"):
>
> Use a longer reset time for ethernet phy Micrel KSZ9031RNX. Otherwise a
> small percentage of modules have 'transmission timeouts' errors like
>
> barebox@Phytec phyFLEX-i.MX6 Quad Carrier-Board:/ ifup eth0
> warning: No MAC address set. Using random address 7e:94:4d:02:f8:f3
> eth0: 1000Mbps full duplex link detected
> eth0: transmission timeout
> T eth0: transmission timeout
> T eth0: transmission timeout
> T eth0: transmission timeout
> T eth0: transmission timeout
>
> Cc: Stefan Christ <s.christ@phytec.de>
> Cc: Christian Hemp <c.hemp@phytec.de>
> Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
Do you want to get this in as a fix or just -next material? If it's a
fix, please have a Fixes tag.
Shawn
> ---
> arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi b/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi
> index 673711f445b6..7e53ac6cfa8a 100644
> --- a/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi
> @@ -91,6 +91,7 @@
> pinctrl-0 = <&pinctrl_enet>;
> phy-handle = <ðphy>;
> phy-mode = "rgmii";
> + phy-reset-duration = <10>; /* in msecs */
> phy-reset-gpios = <&gpio3 23 GPIO_ACTIVE_LOW>;
> phy-supply = <&vdd_eth_io_reg>;
> status = "disabled";
> --
> 2.20.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] ARM: dts: pfla02: increase phy reset duration
2019-03-20 8:59 ` Shawn Guo
@ 2019-03-20 10:10 ` Marco Felsch
2019-03-20 11:37 ` Shawn Guo
0 siblings, 1 reply; 4+ messages in thread
From: Marco Felsch @ 2019-03-20 10:10 UTC (permalink / raw)
To: Shawn Guo
Cc: devicetree, robh+dt, linux-imx, kernel, Christian Hemp,
Stefan Christ, linux-arm-kernel
Hi Shawn,
On 19-03-20 16:59, Shawn Guo wrote:
> On Mon, Mar 04, 2019 at 11:49:40AM +0100, Marco Felsch wrote:
> > Increase the reset duration to ensure correct phy functionality. The
> > reset duration is taken from barebox commit 52fdd510de ("ARM: dts:
> > pfla02: use long enough reset for ethernet phy"):
> >
> > Use a longer reset time for ethernet phy Micrel KSZ9031RNX. Otherwise a
> > small percentage of modules have 'transmission timeouts' errors like
> >
> > barebox@Phytec phyFLEX-i.MX6 Quad Carrier-Board:/ ifup eth0
> > warning: No MAC address set. Using random address 7e:94:4d:02:f8:f3
> > eth0: 1000Mbps full duplex link detected
> > eth0: transmission timeout
> > T eth0: transmission timeout
> > T eth0: transmission timeout
> > T eth0: transmission timeout
> > T eth0: transmission timeout
> >
> > Cc: Stefan Christ <s.christ@phytec.de>
> > Cc: Christian Hemp <c.hemp@phytec.de>
> > Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
>
> Do you want to get this in as a fix or just -next material? If it's a
> fix, please have a Fixes tag.
I don't know that either.. IMHO it's a fix but there is no one out their
complaining about such a problem so it can be -next material too.
Please feel free to add:
Fixes: 3180f956668e ("ARM: dts: Phytec imx6q pfla02 and pbab01 support")
Regards,
Marco
> Shawn
>
> > ---
> > arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi b/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi
> > index 673711f445b6..7e53ac6cfa8a 100644
> > --- a/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi
> > +++ b/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi
> > @@ -91,6 +91,7 @@
> > pinctrl-0 = <&pinctrl_enet>;
> > phy-handle = <ðphy>;
> > phy-mode = "rgmii";
> > + phy-reset-duration = <10>; /* in msecs */
> > phy-reset-gpios = <&gpio3 23 GPIO_ACTIVE_LOW>;
> > phy-supply = <&vdd_eth_io_reg>;
> > status = "disabled";
> > --
> > 2.20.1
> >
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] ARM: dts: pfla02: increase phy reset duration
2019-03-20 10:10 ` Marco Felsch
@ 2019-03-20 11:37 ` Shawn Guo
0 siblings, 0 replies; 4+ messages in thread
From: Shawn Guo @ 2019-03-20 11:37 UTC (permalink / raw)
To: Marco Felsch
Cc: devicetree, robh+dt, linux-imx, kernel, Christian Hemp,
Stefan Christ, linux-arm-kernel
On Wed, Mar 20, 2019 at 11:10:40AM +0100, Marco Felsch wrote:
> Hi Shawn,
>
> On 19-03-20 16:59, Shawn Guo wrote:
> > On Mon, Mar 04, 2019 at 11:49:40AM +0100, Marco Felsch wrote:
> > > Increase the reset duration to ensure correct phy functionality. The
> > > reset duration is taken from barebox commit 52fdd510de ("ARM: dts:
> > > pfla02: use long enough reset for ethernet phy"):
> > >
> > > Use a longer reset time for ethernet phy Micrel KSZ9031RNX. Otherwise a
> > > small percentage of modules have 'transmission timeouts' errors like
> > >
> > > barebox@Phytec phyFLEX-i.MX6 Quad Carrier-Board:/ ifup eth0
> > > warning: No MAC address set. Using random address 7e:94:4d:02:f8:f3
> > > eth0: 1000Mbps full duplex link detected
> > > eth0: transmission timeout
> > > T eth0: transmission timeout
> > > T eth0: transmission timeout
> > > T eth0: transmission timeout
> > > T eth0: transmission timeout
> > >
> > > Cc: Stefan Christ <s.christ@phytec.de>
> > > Cc: Christian Hemp <c.hemp@phytec.de>
> > > Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
> >
> > Do you want to get this in as a fix or just -next material? If it's a
> > fix, please have a Fixes tag.
>
> I don't know that either.. IMHO it's a fix but there is no one out their
> complaining about such a problem so it can be -next material too.
>
> Please feel free to add:
>
> Fixes: 3180f956668e ("ARM: dts: Phytec imx6q pfla02 and pbab01 support")
Applied as fix, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-03-20 11:37 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-04 10:49 [PATCH] ARM: dts: pfla02: increase phy reset duration Marco Felsch
2019-03-20 8:59 ` Shawn Guo
2019-03-20 10:10 ` Marco Felsch
2019-03-20 11:37 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).