From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Mark Brown <broonie@kernel.org>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
alsa-devel@alsa-project.org, patches@opensource.cirrus.com,
lgirdwood@gmail.com, robh+dt@kernel.org
Subject: Re: [PATCH 1/2] ASoC: lochnagar: Add device tree binding document
Date: Wed, 20 Mar 2019 17:05:29 +0000 [thread overview]
Message-ID: <20190320170529.GV46536@ediswmail.ad.cirrus.com> (raw)
In-Reply-To: <20190320165251.GC27518@sirena.org.uk>
On Wed, Mar 20, 2019 at 04:52:51PM +0000, Mark Brown wrote:
> On Wed, Mar 20, 2019 at 02:28:12PM +0000, Charles Keepax wrote:
>
> > + - clock-names : Must include the following clocks:
> > + "ln-sound-mclk" Master clock source for the sound card, should
> > + normally be set to LOCHNAGAR_SOUNDCARD_MCLK provided by the
> > + Lochnagar clock driver.
>
> Why the namespacing on the clock name here?
I think this is just a hang over from when these clocks were not
handled through DT and thus had to have the same name as was used
in the clock driver. Agree it is redundant now and will remove,
maybe even just mclk should be fine I guess, as the sound is
kinda redundant as well.
Thanks,
Charles
prev parent reply other threads:[~2019-03-20 17:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-20 14:28 [PATCH 1/2] ASoC: lochnagar: Add device tree binding document Charles Keepax
2019-03-20 14:28 ` [PATCH 2/2] ASoC: lochnagar: Add driver to support Lochnagar 2 sound card Charles Keepax
2019-03-20 16:52 ` [PATCH 1/2] ASoC: lochnagar: Add device tree binding document Mark Brown
2019-03-20 17:05 ` Charles Keepax [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190320170529.GV46536@ediswmail.ad.cirrus.com \
--to=ckeepax@opensource.cirrus.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=mark.rutland@arm.com \
--cc=patches@opensource.cirrus.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).