From: Lee Jones <lee.jones@linaro.org>
To: Dan Murphy <dmurphy@ti.com>
Cc: Jacek Anaszewski <jacek.anaszewski@gmail.com>,
robh+dt@kernel.org, pavel@ucw.cz, tony@atomide.com,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-leds@vger.kernel.org
Subject: Re: [PATCH v4 4/4] leds: lm3532: Introduce the lm3532 LED driver
Date: Thu, 21 Mar 2019 08:21:39 +0000 [thread overview]
Message-ID: <20190321082139.GS4731@dell> (raw)
In-Reply-To: <7b3d8a13-d255-e36e-979b-cbd337078d30@ti.com>
On Wed, 20 Mar 2019, Dan Murphy wrote:
> On 3/20/19 1:59 PM, Jacek Anaszewski wrote:
> > On 3/13/19 1:32 PM, Dan Murphy wrote:
> >> Introduce the Texas Instruments LM3532 White LED driver.
> >> The driver supports ALS configurability or manual brightness
> >> control.
> >>
> >> The driver also supports associating LED strings with specific
> >> control banks in a group or as individually controlled strings.
> >>
> >> Signed-off-by: Dan Murphy <dmurphy@ti.com>
> >> ---
> >>
> >> v4 - Updated code to DT doc changes appending "ti," to TI specific properties -
> >> https://lore.kernel.org/patchwork/patch/1050124/
> >>
> >> v3 - Removed switch case for register setting in favor of an algorithim (v1 comment),
> >> https://lore.kernel.org/patchwork/patch/1049024/
> >> v2 - Added look up tables for als_avg, als_imp and ramp times, fixed brightness
> >> control when ALS is in control, added property value checks to ensure the values
> >> are not out of bounds - https://lore.kernel.org/patchwork/patch/1048807/
> >>
> >> drivers/leds/Kconfig | 10 +
> >> drivers/leds/Makefile | 1 +
> >> drivers/leds/leds-lm3532.c | 681 +++++++++++++++++++++++++++++++++++++
> >> 3 files changed, 692 insertions(+)
> >> create mode 100644 drivers/leds/leds-lm3532.c
[snip 700 lines of churn]
> Ack. I give post v5 tomorrow.
Same for you too please Dan.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2019-03-21 8:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-13 12:32 [PATCH v4 1/4] dt: lm3532: Add lm3532 dt doc and update ti_lmu doc Dan Murphy
2019-03-13 12:32 ` [PATCH v4 2/4] ARM: dts: omap4-droid4: Update backlight dt properties Dan Murphy
2019-03-13 12:32 ` [PATCH v4 3/4] mfd: ti-lmu: Remove LM3532 backlight driver references Dan Murphy
2019-03-13 12:32 ` [PATCH v4 4/4] leds: lm3532: Introduce the lm3532 LED driver Dan Murphy
2019-03-20 12:39 ` Dan Murphy
2019-03-20 19:00 ` Jacek Anaszewski
2019-03-20 19:05 ` Dan Murphy
2019-03-20 18:59 ` Jacek Anaszewski
2019-03-20 19:04 ` Dan Murphy
2019-03-21 8:21 ` Lee Jones [this message]
2019-03-21 8:20 ` Lee Jones
2019-03-14 9:39 ` [PATCH v4 1/4] dt: lm3532: Add lm3532 dt doc and update ti_lmu doc Pavel Machek
2019-03-14 12:52 ` Dan Murphy
2019-03-15 23:35 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190321082139.GS4731@dell \
--to=lee.jones@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).