From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthias Kaehlcke Subject: Re: [PATCH 4/4] ARM: dts: rockchip: Remove #address/#size-cells from rk3288-veyron gpio-keys Date: Thu, 21 Mar 2019 14:14:26 -0700 Message-ID: <20190321211426.GT112750@google.com> References: <20190320201402.114309-1-dianders@chromium.org> <20190320201402.114309-4-dianders@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Content-Disposition: inline In-Reply-To: <20190320201402.114309-4-dianders@chromium.org> Sender: linux-kernel-owner@vger.kernel.org To: Douglas Anderson Cc: Heiko Stuebner , ryandcase@chromium.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, Rob Herring , Mark Rutland , linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org On Wed, Mar 20, 2019 at 01:14:02PM -0700, Douglas Anderson wrote: > They are pointless. As dtc points out: > Warning (avoid_unnecessary_addr_size): > /gpio-keys: > unnecessary #address-cells/#size-cells without "ranges" or child "reg" property > > Let's remove them. > > Signed-off-by: Douglas Anderson > --- > > arch/arm/boot/dts/rk3288-veyron.dtsi | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/arch/arm/boot/dts/rk3288-veyron.dtsi b/arch/arm/boot/dts/rk3288-veyron.dtsi > index 0bc2409f6903..192dbc089ade 100644 > --- a/arch/arm/boot/dts/rk3288-veyron.dtsi > +++ b/arch/arm/boot/dts/rk3288-veyron.dtsi > @@ -25,8 +25,6 @@ > > gpio_keys: gpio-keys { > compatible = "gpio-keys"; > - #address-cells = <1>; > - #size-cells = <0>; > > pinctrl-names = "default"; > pinctrl-0 = <&pwr_key_l>; Reviewed-by: Matthias Kaehlcke