From: "Jonathan Neuschäfer" <j.neuschaefer@gmx.net>
To: Shawn Guo <shawnguo@kernel.org>
Cc: "Alexander Kurz" <akurz@blala.de>,
"Jonathan Neuschäfer" <j.neuschaefer@gmx.net>,
"Sascha Hauer" <kernel@pengutronix.de>,
"Fabio Estevam" <fabio.estevam@nxp.com>,
devicetree@vger.kernel.org
Subject: Re: [PATCH 1/3] ARM: dts: i.MX50: Add i2c, mmc and spi aliases
Date: Fri, 22 Mar 2019 13:01:06 +0100 [thread overview]
Message-ID: <20190322120106.GC2095@latitude> (raw)
In-Reply-To: <20190322014928.GU12513@dragon>
[-- Attachment #1: Type: text/plain, Size: 937 bytes --]
On Fri, Mar 22, 2019 at 09:49:29AM +0800, Shawn Guo wrote:
> On Fri, Mar 15, 2019 at 09:14:21PM +0000, Alexander Kurz wrote:
> > Using aliases, the devices will be enumerated properly.
> >
> > Signed-off-by: Alexander Kurz <akurz@blala.de>
> > ---
> > arch/arm/boot/dts/imx50.dtsi | 9 +++++++++
> > 1 file changed, 9 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/imx50.dtsi b/arch/arm/boot/dts/imx50.dtsi
> > index ee1e3e8bf4ec..82e7acd7fc2a 100644
> > --- a/arch/arm/boot/dts/imx50.dtsi
> > +++ b/arch/arm/boot/dts/imx50.dtsi
> > @@ -26,11 +26,20 @@
> > gpio3 = &gpio4;
> > gpio4 = &gpio5;
> > gpio5 = &gpio6;
> > + i2c0 = &i2c1;
> > + i2c1 = &i2c2;
>
> Reminded by Jonathan's patch, i2c3 is missing here. I just fixed it up.
> Let's me know if you have a reason for not adding i2c3.
>
> Shawn
Thanks. With this addition, Alexander's patch looks good to me.
Jonathan Neuschäfer
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-03-22 12:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-15 21:14 [PATCH 1/3] ARM: dts: i.MX50: Add i2c, mmc and spi aliases Alexander Kurz
2019-03-15 21:14 ` [PATCH 2/3] ARM: dts: i.MX6SL: Add i2c and mmc aliases Alexander Kurz
2019-03-15 21:14 ` [PATCH 3/3] ARM: dts: i.MX35: " Alexander Kurz
2019-03-22 0:17 ` [PATCH 1/3] ARM: dts: i.MX50: Add i2c, mmc and spi aliases Shawn Guo
2019-03-22 1:49 ` Shawn Guo
2019-03-22 12:01 ` Jonathan Neuschäfer [this message]
2019-03-23 16:41 ` Alexander Kurz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190322120106.GC2095@latitude \
--to=j.neuschaefer@gmx.net \
--cc=akurz@blala.de \
--cc=devicetree@vger.kernel.org \
--cc=fabio.estevam@nxp.com \
--cc=kernel@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).