From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Vinod Koul <vkoul@kernel.org>
Cc: Andy Gross <andy.gross@linaro.org>,
linux-arm-msm@vger.kernel.org, Shawn Guo <shawn.guo@linaro.org>,
David Brown <david.brown@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org,
Abhinav Asati <asatiabhi@codeaurora.org>
Subject: Re: [PATCH 4/6] arm64: dts: qcom: qcs404: Enable blsp1_uart3 for qcs404-evb
Date: Sun, 24 Mar 2019 09:55:17 -0700 [thread overview]
Message-ID: <20190324165517.GH27005@builder> (raw)
In-Reply-To: <20190324163209.17312-5-vkoul@kernel.org>
On Sun 24 Mar 09:32 PDT 2019, Vinod Koul wrote:
> From: Shawn Guo <shawn.guo@linaro.org>
>
> It defines pinctrl settings for blsp1_uart3 in board level dts and
> enable the device by toggling 'status'.
>
> Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
> Signed-off-by: Abhinav Asati <asatiabhi@codeaurora.org>
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
How about a review of this patch instead?
https://lore.kernel.org/lkml/20190305070823.11845-1-bjorn.andersson@linaro.org/
Regards,
Bjorn
> ---
> arch/arm64/boot/dts/qcom/qcs404-evb.dtsi | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/qcs404-evb.dtsi b/arch/arm64/boot/dts/qcom/qcs404-evb.dtsi
> index 323f9633084b..d4fadeaa0bbc 100644
> --- a/arch/arm64/boot/dts/qcom/qcs404-evb.dtsi
> +++ b/arch/arm64/boot/dts/qcom/qcs404-evb.dtsi
> @@ -7,6 +7,7 @@
> / {
> aliases {
> serial0 = &blsp1_uart2;
> + serial1 = &blsp1_uart3;
> };
>
> chosen {
> @@ -137,6 +138,11 @@
> };
>
> &tlmm {
> + blsp1_uart3_default: blsp1-uart3-default {
> + drive-strength = <2>;
> + bias-disable;
> + };
> +
> sdc1_on: sdc1-on {
> clk {
> pins = "sdc1_clk";
> @@ -205,3 +211,7 @@
> bias-disable;
> };
> };
> +
> +&blsp1_uart3 {
> + status = "okay";
> +};
> --
> 2.20.1
>
next prev parent reply other threads:[~2019-03-24 16:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-24 16:32 [PATCH 0/6] arm64: dts: qcom: qcs404: ethernet and other updates Vinod Koul
2019-03-24 16:32 ` [PATCH 1/6] arm64: dts: qcom: qcs404: Add Ethernet node Vinod Koul
2019-03-24 16:32 ` [PATCH 2/6] arm64: dts: qcom: qcs404: Enable ethernet for EVB-4000 Vinod Koul
2019-03-24 16:32 ` [PATCH 3/6] arm64: dts: qcom: qcs404: Fix voltages for s5 and l3 Vinod Koul
2019-03-24 16:32 ` [PATCH 4/6] arm64: dts: qcom: qcs404: Enable blsp1_uart3 for qcs404-evb Vinod Koul
2019-03-24 16:55 ` Bjorn Andersson [this message]
2019-03-25 8:28 ` Vinod Koul
2019-03-24 16:32 ` [PATCH 5/6] arm64: dts: qcom: pms405: add spmi regulators Vinod Koul
2019-03-24 16:57 ` Bjorn Andersson
2019-03-24 16:32 ` [PATCH 6/6] arm64: dts: qcom: qcs404: Remove default setting of controlled-remotely for BAM DMA Vinod Koul
2019-03-24 17:01 ` [PATCH 0/6] arm64: dts: qcom: qcs404: ethernet and other updates Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190324165517.GH27005@builder \
--to=bjorn.andersson@linaro.org \
--cc=andy.gross@linaro.org \
--cc=asatiabhi@codeaurora.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=shawn.guo@linaro.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).