From: Vinod Koul <vkoul@kernel.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Andy Gross <andy.gross@linaro.org>,
David Brown <david.brown@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: qcs404-evb: Enable uart3 and add Bluetooth
Date: Mon, 25 Mar 2019 13:57:50 +0530 [thread overview]
Message-ID: <20190325082750.GO5348@vkoul-mobl> (raw)
In-Reply-To: <20190305070823.11845-1-bjorn.andersson@linaro.org>
On 04-03-19, 23:08, Bjorn Andersson wrote:
> Enable blsp1_uart3, define its pinconf and add the bluetooth node.
>
> It seems provisioning is lacking a valid BD address, preventing the
> interface from initializing, so provide a dummy for now.
This looks good though I need to hand edit the patch order a bit when
applied on top of the series I sent..
Reviewed-by: Vinod Koul <vkoul@kernel.org>
Tested-by: Vinod Koul <vkoul@kernel.org>
>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
> arch/arm64/boot/dts/qcom/qcs404-evb.dtsi | 45 ++++++++++++++++++++++++
> 1 file changed, 45 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/qcs404-evb.dtsi b/arch/arm64/boot/dts/qcom/qcs404-evb.dtsi
> index 536f735243d2..5c502e6db424 100644
> --- a/arch/arm64/boot/dts/qcom/qcs404-evb.dtsi
> +++ b/arch/arm64/boot/dts/qcom/qcs404-evb.dtsi
> @@ -7,6 +7,7 @@
> / {
> aliases {
> serial0 = &blsp1_uart2;
> + serial1 = &blsp1_uart3;
> };
>
> chosen {
> @@ -19,6 +20,32 @@
> regulator-always-on;
> regulator-boot-on;
> };
> +
> + vdd_ch0_3p3:
> + vdd_esmps3_3p3: vdd-esmps3-3p3-regulator {
> + compatible = "regulator-fixed";
> + regulator-name = "eSMPS3_3P3";
> +
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> + regulator-always-on;
> + };
> +};
> +
> +&blsp1_uart3 {
> + status = "okay";
> +
> + bluetooth {
> + compatible = "qcom,wcn3990-bt";
> + vddio-supply = <&vreg_l6_1p8>;
> + vddxo-supply = <&vreg_l5_1p8>;
> + vddrf-supply = <&vreg_l1_1p3>;
> + vddch0-supply = <&vdd_ch0_3p3>;
> +
> + local-bd-address = [ 02 00 00 00 5a ad ];
> +
> + max-speed = <3200000>;
> + };
> };
>
> &remoteproc_adsp {
> @@ -205,3 +232,21 @@
> bias-disable;
> };
> };
> +
> +&blsp1_uart3_default {
> + cts {
> + pins = "gpio84";
> + bias-disable;
> + };
> +
> + rts-tx {
> + pins = "gpio85", "gpio82";
> + drive-strength = <2>;
> + bias-disable;
> + };
> +
> + rx {
> + pins = "gpio83";
> + bias-pull-up;
> + };
> +};
> --
> 2.18.0
--
~Vinod
prev parent reply other threads:[~2019-03-25 8:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-05 7:08 [PATCH] arm64: dts: qcom: qcs404-evb: Enable uart3 and add Bluetooth Bjorn Andersson
2019-03-25 8:27 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190325082750.GO5348@vkoul-mobl \
--to=vkoul@kernel.org \
--cc=andy.gross@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox