From: Shawn Guo <shawnguo@kernel.org>
To: Rui Miguel Silva <rui.silva@linaro.org>
Cc: Rob Herring <robh+dt@kernel.org>,
Fabio Estevam <fabio.estevam@nxp.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
devicetree@vger.kernel.org
Subject: Re: [PATCH 4/5] ARM: dts: imx7s-warp: add csi and mipi_csi node
Date: Tue, 26 Mar 2019 16:25:15 +0800 [thread overview]
Message-ID: <20190326082514.GG12513@dragon> (raw)
In-Reply-To: <20190319170003.21261-5-rui.silva@linaro.org>
On Tue, Mar 19, 2019 at 05:00:02PM +0000, Rui Miguel Silva wrote:
> Add and enable csi and mipi_csi nodes.
>
> Signed-off-by: Rui Miguel Silva <rui.silva@linaro.org>
> ---
> arch/arm/boot/dts/imx7s-warp.dts | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx7s-warp.dts b/arch/arm/boot/dts/imx7s-warp.dts
> index 23431faecaf4..5158c2d958a7 100644
> --- a/arch/arm/boot/dts/imx7s-warp.dts
> +++ b/arch/arm/boot/dts/imx7s-warp.dts
> @@ -277,6 +277,16 @@
> status = "okay";
> };
>
> +&csi {
Please keep the labeled nodes sort alphabetically.
> + status = "okay";
> +};
> +
> +&mipi_csi {
> + clock-frequency = <166000000>;
> + status = "okay";
We usually end property list with 'status'.
Shawn
> + fsl,csis-hs-settle = <3>;
> +};
> +
> &wdog1 {
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_wdog>;
> --
> 2.21.0
>
next prev parent reply other threads:[~2019-03-26 8:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-19 16:59 [PATCH 0/5] ARM: imx7s: add media nodes Rui Miguel Silva
2019-03-19 16:59 ` [PATCH 1/5] ARM: dts: imx7s: add mipi phy power domain Rui Miguel Silva
2019-03-19 17:00 ` [PATCH 2/5] ARM: dts: imx7s: add multiplexer controls Rui Miguel Silva
2019-03-19 17:00 ` [PATCH 3/5] ARM: dts: imx7s: Add video mux, csi and mipi_csi Rui Miguel Silva
2019-03-26 8:23 ` Shawn Guo
2019-03-19 17:00 ` [PATCH 4/5] ARM: dts: imx7s-warp: add csi and mipi_csi node Rui Miguel Silva
2019-03-26 8:25 ` Shawn Guo [this message]
2019-03-19 17:00 ` [PATCH 5/5] ARM: dts: imx7s-warp: add ov2680 sensor node Rui Miguel Silva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190326082514.GG12513@dragon \
--to=shawnguo@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=fabio.estevam@nxp.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=robh+dt@kernel.org \
--cc=rui.silva@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).