From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexandre Belloni Subject: Re: [PATCH v11 6/8] rtc: bd70528: Initial support for ROHM bd70528 RTC Date: Tue, 26 Mar 2019 15:05:52 +0100 Message-ID: <20190326140552.GS30105@piout.net> References: <901900e12e2a06865b3649ec94af511fcc6443a3.1553515333.git.matti.vaittinen@fi.rohmeurope.com> <20190325170451.GQ30105@piout.net> <1db28c6d6223f2c052c0853121fd7b7aa6f7b227.camel@fi.rohmeurope.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1db28c6d6223f2c052c0853121fd7b7aa6f7b227.camel@fi.rohmeurope.com> Sender: linux-kernel-owner@vger.kernel.org To: "Vaittinen, Matti" Cc: "linux-kernel@vger.kernel.org" , "robh+dt@kernel.org" , "mazziesaccount@gmail.com" , "mturquette@baylibre.com" , "devicetree@vger.kernel.org" , "linux-pm@vger.kernel.org" , "sre@kernel.org" , "linus.walleij@linaro.org" , "sboyd@kernel.org" , "lee.jones@linaro.org" , "a.zummo@towertech.it" , "broonie@kernel.org" , "linux-gpio@vger.kernel.org" , "mark.rutland@arm.com" , "linux-watchdog@vger.kernel.org" , Mutanen, List-Id: devicetree@vger.kernel.org On 26/03/2019 13:51:40+0000, Vaittinen, Matti wrote: > On Mon, 2019-03-25 at 18:04 +0100, Alexandre Belloni wrote: > > On 25/03/2019 14:06:42+0200, Matti Vaittinen wrote: > > > Support RTC block in ROHM bd70528 power management IC. Support > > > getting and setting the time and date as well as arming an alarm > > > which can also be used to wake the PMIC from standby state. > > > > > > HW supports wake interrupt only for the next 24 hours (sec, minute > > > and hour information only) so we limit also the alarm interrupt to > > > this 24 hours for the sake of consistency. > > > > > > Signed-off-by: Matti Vaittinen > > > > Acked-by: Alexandre Belloni > > > > > + r->time.hour |= BD70528_MASK_RTC_HOUR_24H; > > > + r->day |= bin2bcd(t->tm_mday); > > > + r->week |= bin2bcd(t->tm_wday); > > > + r->month |= bin2bcd(t->tm_mon + 1); > > > + r->year = bin2bcd(t->tm_year-100); > > > > If you ever have to resend, please add spaces around that - > > Good catch, thanks! I wonder why I didn't get checkpatch warning... I > should've had one. (I usually do run checkpatch). > checkpatch --strict would tell you. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com