From: Rob Herring <robh@kernel.org>
To: Josef Lusticky <josef@lusticky.cz>
Cc: devicetree@vger.kernel.org, maxime.ripard@bootlin.com,
dri-devel@lists.freedesktop.org, airlied@linux.ie,
thierry.reding@gmail.com
Subject: Re: [RFC PATCH 2/2] dt-bindings: panel: Add Ilitek ILI9341 panel documentation
Date: Wed, 27 Mar 2019 15:55:53 -0500 [thread overview]
Message-ID: <20190327205553.GA18019@bogus> (raw)
In-Reply-To: <20190304125033.28841-3-josef@lusticky.cz>
On Mon, Mar 04, 2019 at 01:50:33PM +0100, Josef Lusticky wrote:
> ---
You need a commit message and a Signed-off-by. Run checkpatch.pl, it
will tell you these things.
> .../bindings/display/panel/ilitek,ili9341.txt | 33 +++++++++++++++++++
> 1 file changed, 33 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/panel/ilitek,ili9341.txt
>
> diff --git a/Documentation/devicetree/bindings/display/panel/ilitek,ili9341.txt b/Documentation/devicetree/bindings/display/panel/ilitek,ili9341.txt
> new file mode 100644
> index 000000000000..4e0e483bc12e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/ilitek,ili9341.txt
I don't like the same h/w being documented in 2 places as we already
have bindings/display/ilitek,ili9341.txt. Expand that to cover both
modes.
> @@ -0,0 +1,33 @@
> +Ilitek ILI9341 TFT panel driver with SPI control bus
> +
> +This is a driver for 240x320 TFT panels with parallel RGB color input.
> +
> +Required properties:
> + - compatible: "displaytech,dt024ctft", "ilitek,ili9341"
> + - backlight: phandle of the backlight device attached to the panel
> +
> +Optional properties:
> + - dc-gpios: a GPIO spec for the Data/Command pin, see gpio/gpio.txt
How is this optional? Looks pretty important from reading the driver.
> + - reset-gpios: a GPIO spec for the reset pin, see gpio/gpio.txt
> +
> +The panel must obey the rules for a SPI slave device as specified in
> +spi/spi-bus.txt
> +
> +The device node can contain one 'port' child node with one child
> +'endpoint' node, according to the bindings defined in
> +media/video-interfaces.txt. This node should describe panel's video bus.
> +
> +Example:
> +
> +panel@0 {
> + compatible = "displaytech,dt024ctft", "ilitek,ili9341";
> + reg = <0>;
> + backlight = <&backlight>;
> + dc-gpios = <&pio 4 9 GPIO_ACTIVE_HIGH>;
> +
> + port {
> + panel_in: endpoint {
> + remote-endpoint = <&display_out>;
> + };
> + };
> +};
> --
> 2.20.1
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-03-27 20:55 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-04 12:50 [RFC PATCH 0/2] Add DRM panel driver for Ilitek ILI9341 based panels in parallel RGB mode Josef Lusticky
2019-03-04 12:50 ` [RFC PATCH 1/2] drm/panel: Add Ilitek ILI9341 parallel RGB panel driver Josef Lusticky
2019-03-27 21:00 ` Rob Herring
2019-03-04 12:50 ` [RFC PATCH 2/2] dt-bindings: panel: Add Ilitek ILI9341 panel documentation Josef Lusticky
2019-03-27 20:55 ` Rob Herring [this message]
2019-07-08 14:56 ` [PATCH v2 0/2] Add DRM ILI9341 parallel RGB panel driver Josef Lusticky
2019-07-08 14:56 ` [PATCH v2 1/2] dt-bindings: panel: Add parallel RGB mode for Ilitek ILI9341 panels Josef Lusticky
2019-07-10 13:39 ` Sam Ravnborg
2019-07-24 19:57 ` Rob Herring
2019-07-26 5:56 ` Josef Luštický
2019-07-08 14:56 ` [PATCH v2 2/2] drm/panel: Add Ilitek ILI9341 parallel RGB panel driver Josef Lusticky
2019-07-10 13:47 ` Sam Ravnborg
2019-07-12 9:53 ` Josef Luštický
2019-07-10 13:51 ` [PATCH v2 0/2] Add DRM " Sam Ravnborg
2019-07-26 12:25 ` Controllers with several interface options - one or more drivers? Sam Ravnborg
2019-07-26 14:55 ` Daniel Vetter
2019-07-26 15:06 ` Daniel Vetter
2019-07-26 16:14 ` Sam Ravnborg
2019-07-29 7:19 ` Josef Luštický
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190327205553.GA18019@bogus \
--to=robh@kernel.org \
--cc=airlied@linux.ie \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=josef@lusticky.cz \
--cc=maxime.ripard@bootlin.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).