[PATCH 1/2] dt-bindings: pps: pps-gpio.txt: Add capture-clear

[PATCH 1/2] dt-bindings: pps: pps-gpio.txt: Add capture-clear

[Adrian Bunk]

The code was already there but the device tree wiring was missing.

Signed-off-by: Adrian Bunk <bunk@kernel.org>
Cc: stable@vger.kernel.org
---
 Documentation/devicetree/bindings/pps/pps-gpio.txt | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/pps/pps-gpio.txt b/Documentation/devicetree/bindings/pps/pps-gpio.txt
index 3683874832ae..bb69b8dc7a82 100644
--- a/Documentation/devicetree/bindings/pps/pps-gpio.txt
+++ b/Documentation/devicetree/bindings/pps/pps-gpio.txt
@@ -10,6 +10,7 @@ Required properties:
 Optional properties:
 - assert-falling-edge: when present, assert is indicated by a falling edge
                        (instead of by a rising edge)
+- capture-clear: when present, also capture the clear edge
 
 Example:
 	pps {
-- 
2.20.1

[PATCH 2/2] pps-gpio.c: Add capture-clear

[Adrian Bunk]

The code was already there but the device tree wiring was missing,
resulting in out-of-tree patches enabling it in various places.

This is safe to backport since it only has an effect if enabled
in the device tree.

Signed-off-by: Adrian Bunk <bunk@kernel.org>
Cc: stable@vger.kernel.org
---
 drivers/pps/clients/pps-gpio.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/pps/clients/pps-gpio.c b/drivers/pps/clients/pps-gpio.c
index dd5d1103e02b..f6549c4c9c81 100644
--- a/drivers/pps/clients/pps-gpio.c
+++ b/drivers/pps/clients/pps-gpio.c
@@ -119,6 +119,8 @@ static int pps_gpio_probe(struct platform_device *pdev)
 
 		if (of_get_property(np, "assert-falling-edge", NULL))
 			data->assert_falling_edge = true;
+		if (of_get_property(np, "capture-clear", NULL))
+			data->capture_clear = true;
 	}
 
 	/* GPIO setup */
-- 
2.20.1

Re: [PATCH 2/2] pps-gpio.c: Add capture-clear

[Rob Herring]

On Mon, Mar 11, 2019 at 10:06 AM Adrian Bunk <bunk@kernel.org> wrote:
>
> The code was already there but the device tree wiring was missing,
> resulting in out-of-tree patches enabling it in various places.
>
> This is safe to backport since it only has an effect if enabled
> in the device tree.

That describes every single patch adding DT support... It may be safe
to backport, but it's not stable material IMO.

You may want to send this to some other list besides the DT list if
you want it applied.

> Signed-off-by: Adrian Bunk <bunk@kernel.org>
> Cc: stable@vger.kernel.org
> ---
>  drivers/pps/clients/pps-gpio.c | 2 ++
>  1 file changed, 2 insertions(+)

Re: [PATCH 1/2] dt-bindings: pps: pps-gpio.txt: Add capture-clear

[Rob Herring]

On Mon, Mar 11, 2019 at 04:59:50PM +0200, Adrian Bunk wrote:
> The code was already there but the device tree wiring was missing.

But patch 2 adds the code...

> 
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
> Cc: stable@vger.kernel.org

This is not stable material IMO.

> ---
>  Documentation/devicetree/bindings/pps/pps-gpio.txt | 1 +
>  1 file changed, 1 insertion(+)

This was discussed at length recently. I still think this is working 
around a limitation in the GPIO/interrupt code, but I'm not going to 
argue more about a single property for a single binding.

With stable dropped:

Acked-by: Rob Herring <robh@kernel.org>