From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH v4 1/6] dt-bindings: ap806: add the cluster clock node in the syscon file Date: Thu, 28 Mar 2019 12:39:24 -0500 Message-ID: <20190328173924.GB26680@bogus> References: <20190325124803.28904-1-gregory.clement@bootlin.com> <20190325124803.28904-2-gregory.clement@bootlin.com> <20190328171350.GA26680@bogus> <87k1gioqrp.fsf@FE-laptop> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <87k1gioqrp.fsf@FE-laptop> Sender: linux-kernel-owner@vger.kernel.org To: Gregory CLEMENT Cc: Stephen Boyd , Mike Turquette , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Jason Cooper , Andrew Lunn , Sebastian Hesselbarth , Thomas Petazzoni , linux-arm-kernel@lists.infradead.org, Antoine Tenart , =?iso-8859-1?Q?Miqu=E8l?= Raynal , Maxime Chevallier List-Id: devicetree@vger.kernel.org On Thu, Mar 28, 2019 at 06:25:14PM +0100, Gregory CLEMENT wrote: > Hi Rob, > > On jeu., mars 28 2019, Rob Herring wrote: > > > On Mon, Mar 25, 2019 at 01:47:58PM +0100, Gregory CLEMENT wrote: > >> Document the device tree binding for the cluster clock controllers found > >> in the Armada 7K/8K SoCs. > >> > >> Signed-off-by: Gregory CLEMENT > >> --- > >> .../arm/marvell/ap806-system-controller.txt | 25 +++++++++++++++++++ > >> 1 file changed, 25 insertions(+) > >> > >> diff --git a/Documentation/devicetree/bindings/arm/marvell/ap806-system-controller.txt b/Documentation/devicetree/bindings/arm/marvell/ap806-system-controller.txt > >> index 7b8b8eb0191f..ceeba18b4ac3 100644 > >> --- a/Documentation/devicetree/bindings/arm/marvell/ap806-system-controller.txt > >> +++ b/Documentation/devicetree/bindings/arm/marvell/ap806-system-controller.txt > >> @@ -143,3 +143,28 @@ ap_syscon1: system-controller@6f8000 { > >> #thermal-sensor-cells = <1>; > >> }; > >> }; > >> + > >> +Cluster clocks: > >> +--------------- > >> + > >> +Device Tree Clock bindings for cluster clock of AP806 Marvell. Each > >> +cluster contain up to 2 CPUs running at the same frequency. > >> + > >> +Required properties: > >> +- compatible: must be "marvell,ap806-cpu-clock"; > >> +- #clock-cells : should be set to 1. > >> +- clocks : shall be the input parents clock phandle for the clock. > >> + > >> +Optional property: > >> + - reg: register range associated the cluser clocks > > > > reg can be optional to use, but should either be there or not. > > OK so let's remove it! If you can define what the registers are, then you should have it even if Linux happens to not care. Rob