From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Fri, 29 Mar 2019 09:22:36 +0000 From: Charles Keepax Subject: Re: [PATCH v4 1/2] hwmon: lochnagar: Add device tree binding document Message-ID: <20190329092236.GL46536@ediswmail.ad.cirrus.com> References: <20190328130937.3756-1-ckeepax@opensource.cirrus.com> <20190328174615.GA6068@bogus> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20190328174615.GA6068@bogus> To: Rob Herring , lee.jones@linaro.org Cc: jdelvare@suse.com, linux@roeck-us.net, mark.rutland@arm.com, linux-hwmon@vger.kernel.org, corbet@lwn.net, devicetree@vger.kernel.org, patches@opensource.cirrus.com List-ID: On Thu, Mar 28, 2019 at 12:46:15PM -0500, Rob Herring wrote: > On Thu, Mar 28, 2019 at 01:09:36PM +0000, Charles Keepax wrote: > > Lochnagar is an evaluation and development board for Cirrus > > Logic Smart CODEC and Amp devices. It allows the connection of > > most Cirrus Logic devices on mini-cards, as well as allowing > > connection of various application processor systems to provide a > > full evaluation platform. This driver supports the board > > controller chip on the Lochnagar board. > > > > Signed-off-by: Charles Keepax > > --- > > +Required properties: > > + > > + - compatible : One of the following strings: > > + "cirrus,lochnagar2-hwmon" > > + > > +Example: > > + > > +lochnagar-hwmon { > > + compatible = "cirrus,lochnagar2-hwmon"; > > You don't have any resources in DT, the parent MFD driver can just > instantiate this child device. > + Lee Jones Lee, was very very keen for me to not mix mfd_add_devices and of_platform_populate in the MFD driver. As such we moved all the sub-drivers into DT. I agree it is a little odd that this exists only to bind in this driver but I think it is probably a bit late to change that. If we were going to have the MFD instantiating children directly a lot of the rest of the binding would have been done very differently. Thanks, Charles