Re: [PATCH 2/2] sifive: edac: Add EDAC driver for Sifive l2 Cache Controller

Paul Walmsley
2019-03-12T16:31:43Z

Hello Yash,

On Tue, 12 Mar 2019, Yash Shah wrote:

> Add driver for the SiFive L2 cache controller
> on the HiFive Unleashed board

This should read "for the SiFive FU540-C000 chip" or something similar.
The L2 cache controller is not specific to the HiFive Unleashed board.

Could you also please describe in your patch description:

1. what features this driver supports - in other words, why would it be
used

2. and, if this driver was written based on any other drivers, please just
briefly credit them. For example, the use of the "teardown_*" function
names suggest that this driver is at least partially based on
i10nm_base.c, skx_base.c, or pnd2_edac.c ?

thanks,

- Paul