From: Rob Herring <robh@kernel.org>
To: michael.hennerich@analog.com
Cc: mike.looijmans@topic.nl, sre@kernel.org,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
robin.getz@analog.com
Subject: Re: [PATCH] power: supply: ltc3651-charger.c: Fix typo in device name
Date: Fri, 29 Mar 2019 11:21:11 -0500 [thread overview]
Message-ID: <20190329162111.GB13068@bogus> (raw)
In-Reply-To: <1553608635-29376-1-git-send-email-michael.hennerich@analog.com>
On Tue, Mar 26, 2019 at 02:57:15PM +0100, michael.hennerich@analog.com wrote:
> From: Michael Hennerich <michael.hennerich@analog.com>
Seems to be a bit more than 'fix a typo'.
>
> There never was a device called LTC3651, it always was just LT3651.
> This circumstance makes it pretty difficult to identify what this
> driver is meant to control. This patch is a minimal invasive attempt
> to fix this issue without affecting existing systems.
>
>
> Signed-off-by: Michael Hennerich <michael.hennerich@analog.com>
> ---
> .../devicetree/bindings/power/supply/ltc3651-charger.txt | 8 +++++---
> drivers/power/supply/Kconfig | 6 +++---
> drivers/power/supply/ltc3651-charger.c | 9 +++------
> 3 files changed, 11 insertions(+), 12 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/power/supply/ltc3651-charger.txt b/Documentation/devicetree/bindings/power/supply/ltc3651-charger.txt
> index 71f2840..f012449 100644
> --- a/Documentation/devicetree/bindings/power/supply/ltc3651-charger.txt
> +++ b/Documentation/devicetree/bindings/power/supply/ltc3651-charger.txt
> @@ -1,7 +1,9 @@
> -ltc3651-charger
> +Analog Devices LT3651 Charger Power Supply bindings: ltc3651-charger
>
> Required properties:
> - - compatible: "lltc,ltc3651-charger"
> +- compatible: Should contain one of the following:
> + * "lltc,ltc3651-charger",
You should note that this one is deprecated.
> + * "lltc,lt3651-charger"
> - lltc,acpr-gpios: Connect to ACPR output. See remark below.
>
> Optional properties:
> @@ -20,7 +22,7 @@ attributes to detect changes.
> Example:
>
> charger: battery-charger {
> - compatible = "lltc,ltc3651-charger";
> + compatible = "lltc,lt3651-charger";
> lltc,acpr-gpios = <&gpio0 68 GPIO_ACTIVE_LOW>;
> lltc,fault-gpios = <&gpio0 64 GPIO_ACTIVE_LOW>;
> lltc,chrg-gpios = <&gpio0 63 GPIO_ACTIVE_LOW>;
next prev parent reply other threads:[~2019-03-29 16:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-26 13:57 [PATCH] power: supply: ltc3651-charger.c: Fix typo in device name michael.hennerich
2019-03-29 16:21 ` Rob Herring [this message]
2019-04-05 14:37 ` Sebastian Reichel
2019-04-05 14:58 ` Hennerich, Michael
2019-04-05 15:11 ` Sebastian Reichel
2019-04-08 8:04 ` Mike Looijmans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190329162111.GB13068@bogus \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=michael.hennerich@analog.com \
--cc=mike.looijmans@topic.nl \
--cc=robin.getz@analog.com \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).