* [PATCH] dt-bindings: hwmon: (adc128d818) Specify ti,mode property size
@ 2019-03-13 14:11 Carlos Menin
2019-03-28 15:19 ` Rob Herring
2019-03-29 16:52 ` Guenter Roeck
0 siblings, 2 replies; 3+ messages in thread
From: Carlos Menin @ 2019-03-13 14:11 UTC (permalink / raw)
To: Jean Delvare, Guenter Roeck, Rob Herring, Mark Rutland
Cc: linux-hwmon, devicetree
By default, cells in DT are 32-bit in size. The driver reads "ti,mode"
using the function of_property_read_u8() which causes the value to be
read incorrectly in little-endian architectures if the size is not
specified.
Make it explicit in the binding documentation that this prorperty must
be set as a 8-bit value.
Signed-off-by: Carlos Menin <menin@carlosaurelio.net>
---
Documentation/devicetree/bindings/hwmon/adc128d818.txt | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/hwmon/adc128d818.txt b/Documentation/devicetree/bindings/hwmon/adc128d818.txt
index 08bab0e..d0ae46d 100644
--- a/Documentation/devicetree/bindings/hwmon/adc128d818.txt
+++ b/Documentation/devicetree/bindings/hwmon/adc128d818.txt
@@ -26,7 +26,7 @@ Required node properties:
Optional node properties:
- - ti,mode: Operation mode (see above).
+ - ti,mode: Operation mode (u8) (see above).
Example (operation mode 2):
@@ -34,5 +34,5 @@ Example (operation mode 2):
adc128d818@1d {
compatible = "ti,adc128d818";
reg = <0x1d>;
- ti,mode = <2>;
+ ti,mode = /bits/ 8 <2>;
};
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] dt-bindings: hwmon: (adc128d818) Specify ti,mode property size
2019-03-13 14:11 [PATCH] dt-bindings: hwmon: (adc128d818) Specify ti,mode property size Carlos Menin
@ 2019-03-28 15:19 ` Rob Herring
2019-03-29 16:52 ` Guenter Roeck
1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring @ 2019-03-28 15:19 UTC (permalink / raw)
To: Carlos Menin
Cc: Jean Delvare, Guenter Roeck, Mark Rutland, linux-hwmon,
devicetree
On Wed, 13 Mar 2019 11:11:26 -0300, Carlos Menin wrote:
> By default, cells in DT are 32-bit in size. The driver reads "ti,mode"
> using the function of_property_read_u8() which causes the value to be
> read incorrectly in little-endian architectures if the size is not
> specified.
>
> Make it explicit in the binding documentation that this prorperty must
> be set as a 8-bit value.
>
> Signed-off-by: Carlos Menin <menin@carlosaurelio.net>
> ---
> Documentation/devicetree/bindings/hwmon/adc128d818.txt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: hwmon: (adc128d818) Specify ti,mode property size
2019-03-13 14:11 [PATCH] dt-bindings: hwmon: (adc128d818) Specify ti,mode property size Carlos Menin
2019-03-28 15:19 ` Rob Herring
@ 2019-03-29 16:52 ` Guenter Roeck
1 sibling, 0 replies; 3+ messages in thread
From: Guenter Roeck @ 2019-03-29 16:52 UTC (permalink / raw)
To: Carlos Menin
Cc: Jean Delvare, Rob Herring, Mark Rutland, linux-hwmon, devicetree
On Wed, Mar 13, 2019 at 11:11:26AM -0300, Carlos Menin wrote:
> By default, cells in DT are 32-bit in size. The driver reads "ti,mode"
> using the function of_property_read_u8() which causes the value to be
> read incorrectly in little-endian architectures if the size is not
> specified.
>
> Make it explicit in the binding documentation that this prorperty must
> be set as a 8-bit value.
>
> Signed-off-by: Carlos Menin <menin@carlosaurelio.net>
> Reviewed-by: Rob Herring <robh@kernel.org>
Applied.
Thanks,
Guenter
> ---
> Documentation/devicetree/bindings/hwmon/adc128d818.txt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/hwmon/adc128d818.txt b/Documentation/devicetree/bindings/hwmon/adc128d818.txt
> index 08bab0e..d0ae46d 100644
> --- a/Documentation/devicetree/bindings/hwmon/adc128d818.txt
> +++ b/Documentation/devicetree/bindings/hwmon/adc128d818.txt
> @@ -26,7 +26,7 @@ Required node properties:
>
> Optional node properties:
>
> - - ti,mode: Operation mode (see above).
> + - ti,mode: Operation mode (u8) (see above).
>
>
> Example (operation mode 2):
> @@ -34,5 +34,5 @@ Example (operation mode 2):
> adc128d818@1d {
> compatible = "ti,adc128d818";
> reg = <0x1d>;
> - ti,mode = <2>;
> + ti,mode = /bits/ 8 <2>;
> };
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-03-29 16:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-13 14:11 [PATCH] dt-bindings: hwmon: (adc128d818) Specify ti,mode property size Carlos Menin
2019-03-28 15:19 ` Rob Herring
2019-03-29 16:52 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).