devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Shinji Kanematsu <kanematsu.shinji@socionext.com>
Cc: robh+dt@kernel.org, mark.rutland@arm.com, knaack.h@gmx.de,
	lars@metafoo.de, pmeerw@pmeerw.net, linux-iio@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	masami.hiramatsu@linaro.org, jaswinder.singh@linaro.org,
	orito.takao@socionext.com, sugaya.taichi@socionext.com,
	kasai.kazuhiro@socionext.com,
	William Breathitt Gray <vilhelm.gray@gmail.com>
Subject: Re: [PATCH 0/2] Add Updown Counter support for Milbeaut M10V SoC
Date: Sat, 30 Mar 2019 18:36:03 +0000	[thread overview]
Message-ID: <20190330183603.55886d4f@archlinux> (raw)
In-Reply-To: <1553581954-13487-1-git-send-email-kanematsu.shinji@socionext.com>

On Tue, 26 Mar 2019 15:32:34 +0900
Shinji Kanematsu <kanematsu.shinji@socionext.com> wrote:

> This is a series of patch which adds Updown Counter support on
> Milbeaut M10V SoC.
> 
> The Updown Counter counts input pulse signal from external quadrature encoder.
> It also has input pulse signal counter function.
Hi Shinji,

Are you aware of the counter subsystem that has been proposed (and
as far as I am concerned is ready to be merged)?

https://patchwork.kernel.org/project/linux-iio/list/?series=147
(I think that's the latest version posted)..
William, perhaps you could give an update?

(bad luck, you are getting popular ;)

I'll take a quick review as it stands, as some issues may carry over.
I appreciate that it's always unfortunate to try to upstream stuff at the
same time as a new framework is being developed / upstreamed, but I don't
intend to take any additional counter drivers into IIO.  We just
end up having to maintain old interfaces in more and more drivers.

Thanks,

Jonathan

> 
> Shinji Kanematsu (2):
>   dt-bindings: iio: counter: Add Milbeaut Updown Counter
>   iio: counter: Add support for Milbeaut Updown Counter
> 
>  .../bindings/iio/counter/milbeaut-updown_cnt.txt   |  22 ++
>  drivers/iio/counter/Kconfig                        |  12 +
>  drivers/iio/counter/Makefile                       |   1 +
>  drivers/iio/counter/milbeaut-updown.h              |  38 ++
>  drivers/iio/counter/milbeaut-updown_cnt.c          | 385 +++++++++++++++++++++
>  5 files changed, 458 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/iio/counter/milbeaut-updown_cnt.txt
>  create mode 100644 drivers/iio/counter/milbeaut-updown.h
>  create mode 100644 drivers/iio/counter/milbeaut-updown_cnt.c
> 

  reply	other threads:[~2019-03-30 18:36 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-26  6:32 [PATCH 0/2] Add Updown Counter support for Milbeaut M10V SoC Shinji Kanematsu
2019-03-30 18:36 ` Jonathan Cameron [this message]
2019-03-31  2:09   ` William Breathitt Gray
2019-04-02  6:22     ` Kanematsu, Shinji/兼松 伸次
2019-04-02  2:12   ` Kanematsu, Shinji/兼松 伸次

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190330183603.55886d4f@archlinux \
    --to=jic23@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jaswinder.singh@linaro.org \
    --cc=kanematsu.shinji@socionext.com \
    --cc=kasai.kazuhiro@socionext.com \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=masami.hiramatsu@linaro.org \
    --cc=orito.takao@socionext.com \
    --cc=pmeerw@pmeerw.net \
    --cc=robh+dt@kernel.org \
    --cc=sugaya.taichi@socionext.com \
    --cc=vilhelm.gray@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).