devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jacek Anaszewski <jacek.anaszewski@gmail.com>
To: linux-leds@vger.kernel.org
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	pavel@ucw.cz, robh@kernel.org, jacek.anaszewski@gmail.com,
	Linus Walleij <linus.walleij@linaro.org>
Subject: [PATCH v3 22/25] dt-bindings: leds-gpio: Add function and color properties
Date: Sun, 31 Mar 2019 19:54:58 +0200	[thread overview]
Message-ID: <20190331175501.23471-23-jacek.anaszewski@gmail.com> (raw)
In-Reply-To: <20190331175501.23471-1-jacek.anaszewski@gmail.com>

Refer to new "function" and "color" properties and mark "label"
as deprecated.

Signed-off-by: Jacek Anaszewski <jacek.anaszewski@gmail.com>
Cc: Linus Walleij <linus.walleij@linaro.org>
---
 .../devicetree/bindings/leds/leds-gpio.txt         | 23 +++++++++++++++-------
 1 file changed, 16 insertions(+), 7 deletions(-)

diff --git a/Documentation/devicetree/bindings/leds/leds-gpio.txt b/Documentation/devicetree/bindings/leds/leds-gpio.txt
index a48dda268f81..d21281b63d38 100644
--- a/Documentation/devicetree/bindings/leds/leds-gpio.txt
+++ b/Documentation/devicetree/bindings/leds/leds-gpio.txt
@@ -10,8 +10,12 @@ LED sub-node properties:
 - gpios :  Should specify the LED's GPIO, see "gpios property" in
   Documentation/devicetree/bindings/gpio/gpio.txt.  Active low LEDs should be
   indicated using flags in the GPIO specifier.
-- label :  (optional)
+- function :  (optional)
+  see Documentation/devicetree/bindings/leds/common.txt
+- color :  (optional)
   see Documentation/devicetree/bindings/leds/common.txt
+- label :  (optional)
+  see Documentation/devicetree/bindings/leds/common.txt (deprecated)
 - linux,default-trigger :  (optional)
   see Documentation/devicetree/bindings/leds/common.txt
 - default-state:  (optional) The initial state of the LED.
@@ -27,30 +31,34 @@ LED sub-node properties:
 Examples:
 
 #include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/leds/common.h>
 
 leds {
 	compatible = "gpio-leds";
-	hdd {
-		label = "Disk Activity";
+	led0 {
 		gpios = <&mcu_pio 0 GPIO_ACTIVE_LOW>;
 		linux,default-trigger = "disk-activity";
+		function = LED_FUNCTION_DISK;
 	};
 
-	fault {
+	led1 {
 		gpios = <&mcu_pio 1 GPIO_ACTIVE_HIGH>;
 		/* Keep LED on if BIOS detected hardware fault */
 		default-state = "keep";
+		function = LED_FUNCTION_FAULT;
 	};
 };
 
 run-control {
 	compatible = "gpio-leds";
-	red {
+	led0 {
 		gpios = <&mpc8572 6 GPIO_ACTIVE_HIGH>;
+		color = <LED_COLOR_ID_RED>;
 		default-state = "off";
 	};
-	green {
+	led1 {
 		gpios = <&mpc8572 7 GPIO_ACTIVE_HIGH>;
+		color = <LED_COLOR_ID_GREEN>;
 		default-state = "on";
 	};
 };
@@ -58,9 +66,10 @@ run-control {
 leds {
 	compatible = "gpio-leds";
 
-	charger-led {
+	led0 {
 		gpios = <&gpio1 2 GPIO_ACTIVE_HIGH>;
 		linux,default-trigger = "max8903-charger-charging";
 		retain-state-suspended;
+		function = LED_FUNCTION_CHARGE;
 	};
 };
-- 
2.11.0

  parent reply	other threads:[~2019-03-31 17:54 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-31 17:54 [PATCH v3 00/25] Add generic support for composing LED class device name Jacek Anaszewski
2019-03-31 17:54 ` [PATCH v3 01/25] leds: class: Improve LED and LED flash class registration API Jacek Anaszewski
2019-03-31 17:54 ` [PATCH v3 02/25] dt-bindings: leds: Add LED_FUNCTION definitions Jacek Anaszewski
2019-04-05  1:11   ` Dan Murphy
2019-03-31 17:54 ` [PATCH v3 03/25] dt-bindings: leds: Add LED_COLOR_ID definitions Jacek Anaszewski
2019-04-05  1:12   ` Dan Murphy
2019-03-31 17:54 ` [PATCH v3 04/25] dt-bindings: leds: Add function, color and led-enumerator properties Jacek Anaszewski
2019-03-31 17:54 ` [PATCH v3 05/25] leds: core: Add support for composing LED class device names Jacek Anaszewski
2019-04-05 11:45   ` Dan Murphy
2019-04-05 20:08     ` Jacek Anaszewski
2019-03-31 17:54 ` [PATCH v3 06/25] dt-bindings: sc27xx-blt: Add function and color properties Jacek Anaszewski
2019-03-31 17:54 ` [PATCH v3 07/25] leds: sc27xx-blt: Use generic support for composing LED names Jacek Anaszewski
2019-03-31 17:54 ` [PATCH v3 08/25] dt-bindings: lt3593: Add function and color properties Jacek Anaszewski
2019-03-31 17:54 ` [PATCH v3 09/25] leds: lt3593: Use generic support for composing LED names Jacek Anaszewski
2019-03-31 17:54 ` [PATCH v3 10/25] dt-bindings: lp8860: Add function and color properties Jacek Anaszewski
2019-04-05 11:47   ` Dan Murphy
2019-03-31 17:54 ` [PATCH v3 11/25] leds: lp8860: Use generic support for composing LED names Jacek Anaszewski
2019-04-11 15:28   ` Dan Murphy
2019-03-31 17:54 ` [PATCH v3 12/25] dt-bindings: lm3692x: Add function and color properties Jacek Anaszewski
2019-04-05 11:48   ` Dan Murphy
2019-03-31 17:54 ` [PATCH v3 13/25] leds: lm3692x: Use generic support for composing LED names Jacek Anaszewski
2019-04-11 15:29   ` Dan Murphy
2019-03-31 17:54 ` [PATCH v3 14/25] dt-bindings: lm36010: Add function and color properties Jacek Anaszewski
2019-04-05 11:48   ` Dan Murphy
2019-03-31 17:54 ` [PATCH v3 15/25] leds: lm3601x: Use generic support for composing LED names Jacek Anaszewski
2019-04-11 15:29   ` Dan Murphy
2019-03-31 17:54 ` [PATCH v3 16/25] dt-bindings: cr0014114: Add function and color properties Jacek Anaszewski
2019-03-31 17:54 ` [PATCH v3 17/25] leds: cr0014114: Use generic support for composing LED names Jacek Anaszewski
2019-03-31 17:54 ` [PATCH v3 18/25] dt-bindings: aat1290: Add function and color properties Jacek Anaszewski
2019-03-31 17:54 ` [PATCH v3 19/25] leds: aat1290: Use generic support for composing LED names Jacek Anaszewski
2019-03-31 17:54 ` [PATCH v3 20/25] dt-bindings: as3645a: Add function and color properties Jacek Anaszewski
2019-03-31 17:54 ` [PATCH v3 21/25] leds: as3645a: Use generic support for composing LED names Jacek Anaszewski
2019-03-31 17:54 ` Jacek Anaszewski [this message]
2019-03-31 17:54 ` [PATCH v3 23/25] leds: gpio: " Jacek Anaszewski
2019-03-31 17:55 ` [PATCH v3 24/25] dt-bindings: an30259a: Add function and color properties Jacek Anaszewski
2019-03-31 17:55 ` [PATCH v3 25/25] leds: an30259a: Use generic support for composing LED names Jacek Anaszewski
2019-04-04 13:21 ` [PATCH v3 00/25] Add generic support for composing LED class device name Pavel Machek
2019-04-04 19:18   ` Jacek Anaszewski
2019-04-06  9:46     ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190331175501.23471-23-jacek.anaszewski@gmail.com \
    --to=jacek.anaszewski@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).