From mboxrd@z Thu Jan  1 00:00:00 1970
From: Wolfram Sang <wsa@the-dreams.de>
Subject: Re: [PATCH v5 7/8] i2c: iproc: add NIC I2C support
Date: Tue, 2 Apr 2019 12:27:34 +0200
Message-ID: <20190402102733.GD2960@kunai>
References: <20190214175725.60462-1-ray.jui@broadcom.com>
 <20190214175725.60462-8-ray.jui@broadcom.com>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="6WlEvdN9Dv0WHSBl"
Return-path: <linux-kernel-owner@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <20190214175725.60462-8-ray.jui@broadcom.com>
Sender: linux-kernel-owner@vger.kernel.org
To: Ray Jui <ray.jui@broadcom.com>
Cc: Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com>
List-Id: devicetree@vger.kernel.org


--6WlEvdN9Dv0WHSBl
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline


> +#define IDM_CTRL_DIRECT_OFFSET       0x00

And this IDM thing is also never used outside of the I2C context? In
other words, it also doesn't need a seperate DT node?


> +	/* indicates no slave mode support */
> +	bool no_slave;

I would suggest to not use a flag, but to nullify the {un}reg_slave
callbacks in probe depending on the type. That will also tell the
i2c-core that slave functionality is not supported. And you can use if
(!algo->reg_slave) as a flag, too.

> +	iproc_i2c->type =
> +		(enum bcm_iproc_i2c_type) of_device_get_match_data(&pdev->dev);

No need to cast a void*.


--6WlEvdN9Dv0WHSBl
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAlyjORUACgkQFA3kzBSg
KbZmdw/9GNjBVJL/3oOGEZFDISLOBXCpa+MekxPn+H439sj9T661k+CV8XQZH12K
TcchO9mzMA4w5nMFPKYGw3+aJ6cZXbXuvYwZfXu97u8zrfrN6dLcR4erWZi7/yMR
Ckk0e2lcuOzXVp8JAiLtpWnix1dvc6c0vm4F50n+fD8UjGCkIn/Ur+syRCwsQnMB
JD3Fb8m/Y+g0OSGOLtbJCg4UFnnz4rDrIecRUfUZgukKpL6alRyiKoE2ldQUecrh
8ftdrE0DA0FGnByRjboeLEWWUxMFAF3a3C4OFmytZ8P9nqihTfhwoRIfFLupmywU
bUPHN00gol6EHw1tGPxu2KxuJ0n/yRgGr7ASw+CBbvDgpWhha4hBShT/bCfIufcq
1vIDA5M2wkG12FLn9MbwjjCXAR7WuWZbqI65UgwU4f9OKsbhC28S3siirKUSnRGg
KR5Kv5jTgSZVSSdjWNG5xS1xKh1sp8iQUcQQRaOua60FqmHY1HvKc6HLogLJK5gH
j/ByoLKqy16KTG1uOSmVEtEdNEQ5xiba84UvncJrIQcrvZnZlSQZml8EQ4njoK9Q
vfQmCl7Tyx+S+GKSnMABvsHhvhf1GZf0EFYagwTPUZi4lsoK4Gvu2vu3YvD3D5Zn
CqjsZsUHqW1jLPNYv9hDHO5eov/ZpRa7kJwuxcwmGLuvwbneSFU=
=vf6X
-----END PGP SIGNATURE-----

--6WlEvdN9Dv0WHSBl--