From: Maxime Ripard <maxime.ripard@bootlin.com>
To: Rob Herring <robh+dt@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, Chen-Yu Tsai <wens@csie.org>,
Boris Brezillon <boris.brezillon@collabora.com>,
MTD Maling List <linux-mtd@lists.infradead.org>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Frank Rowand <frowand.list@gmail.com>,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 1/2] dt-bindings: mtd: Add YAML schemas for the generic NAND options
Date: Wed, 3 Apr 2019 09:35:51 +0200 [thread overview]
Message-ID: <20190403073551.ym7nbqwcdpicwo6e@flea> (raw)
In-Reply-To: <CAL_JsqL9rOO8jUUVQ5MnD3GCvyyCDPsw=Kd=va3X-rAF60Wkzg@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 742 bytes --]
Hi Rob,
On Tue, Apr 02, 2019 at 08:20:58PM -0500, Rob Herring wrote:
> > + nand-ecc-strength:
> > + $ref: /schemas/types.yaml#/definitions/uint32
> > + minimum: 1
>
> While I wished this worked, these 2 have to be under 'allOf'.
> Unfortunately, this will also silently pass validation in json-schema.
Unfortunately, I'm not sure I fully get how the ref system is supposed
to work yet. Can you elaborate a bit on why we should put the ref and
whatever constraint we have in an allOf?
Should we do the same in a separate schema that would reference
another entire schema (like the second patch does with the first
one)?
Thanks!
Maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-04-03 7:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-02 14:54 [PATCH v2 1/2] dt-bindings: mtd: Add YAML schemas for the generic NAND options Maxime Ripard
2019-04-02 14:54 ` [PATCH v2 2/2] dt-bindings: mtd: sunxi-nand: Add YAML schemas Maxime Ripard
2019-04-03 1:25 ` Rob Herring
2019-04-03 7:44 ` Maxime Ripard
2019-04-03 8:33 ` Rob Herring
2019-04-03 8:49 ` Maxime Ripard
2019-04-03 1:20 ` [PATCH v2 1/2] dt-bindings: mtd: Add YAML schemas for the generic NAND options Rob Herring
2019-04-03 7:35 ` Maxime Ripard [this message]
2019-04-11 13:19 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190403073551.ym7nbqwcdpicwo6e@flea \
--to=maxime.ripard@bootlin.com \
--cc=boris.brezillon@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=miquel.raynal@bootlin.com \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).