From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Subject: Re: [PATCH v4 3/5] media: sunxi: Add A10 CSI driver Date: Wed, 3 Apr 2019 11:26:55 +0200 Message-ID: <20190403092655.engthyfinpxvndh4@flea> References: <20190403091221.qd5ivgcoviazccv7@paasikivi.fi.intel.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="zchbulmqh2lleyeb" Return-path: Content-Disposition: inline In-Reply-To: <20190403091221.qd5ivgcoviazccv7@paasikivi.fi.intel.com> Sender: linux-kernel-owner@vger.kernel.org To: Sakari Ailus Cc: Hans Verkuil , Mauro Carvalho Chehab , Thomas Petazzoni , Laurent Pinchart , linux-media@vger.kernel.org, Chen-Yu Tsai , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Mark Rutland , Rob Herring , Frank Rowand List-Id: devicetree@vger.kernel.org --zchbulmqh2lleyeb Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Sakari, On Wed, Apr 03, 2019 at 12:12:21PM +0300, Sakari Ailus wrote: > Thanks for the update and my apologies for the late review. > > On Tue, Mar 19, 2019 at 04:55:46PM +0100, Maxime Ripard wrote: > > The older CSI drivers have camera capture interface different from the one > > in the newer ones. > > > > This IP is pretty simple. Some variants (one controller out of two > > instances on some SoCs) have an ISP embedded, but there's no code that make > > use of it, so we ignored that part for now. > > > > Signed-off-by: Maxime Ripard > > Could you add a sub-device for the CSI-2 receiver, please? > > See e.g. drivers/media/pci/intel/ipu3/ipu3-cio2.c for an example. It's confusing, I know, but this isn't a MIPI-CSI receiver. The IP is called CSI, but it's only capable of handling parallel and BT656. Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --zchbulmqh2lleyeb Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXKR8XwAKCRDj7w1vZxhR xWzTAQCO6onvJvAyxQ/6zEc/t+3ODQNIh2Kd0llgRcS0+j8TzgEA+9nsA6jNG3Rt 7u3CgLYRL2TexYqGU4lz12/2fB7ndAA= =riar -----END PGP SIGNATURE----- --zchbulmqh2lleyeb--