From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.kernel.org ([198.145.29.99]:39672 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725963AbfDCKOS (ORCPT ); Wed, 3 Apr 2019 06:14:18 -0400 Date: Wed, 3 Apr 2019 17:14:10 +0700 From: Shawn Guo Subject: Re: [PATCH 1/2] arm64: dts: ls1028a: Add properties for Mali DP500 node Message-ID: <20190403101409.GH7932@X250> References: <20190328035309.18703-1-wen.he_1@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190328035309.18703-1-wen.he_1@nxp.com> Sender: devicetree-owner@vger.kernel.org To: Wen He Cc: "devicetree@vger.kernel.org" , Leo Li , "liviu.dudau@arm.com" , "brian.starkey@arm.com" List-ID: On Thu, Mar 28, 2019 at 03:51:46AM +0000, Wen He wrote: > The LS1028A has a LCD controller and Displayport interface that > connects to eDP and Displayport connectors on the LS1028A board. > > This patch enables the LCD controller driver on the LS1028A. > > Signed-off-by: Alison Wang > Signed-off-by: Wen He > --- > .../arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 37 +++++++++++++++++++ > 1 file changed, 37 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > index 8dd3501b1333..0d5963bb46c5 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > @@ -70,6 +70,27 @@ > clock-output-names = "sysclk"; > }; > > + dpclk: dpclk { Please follow the naming convention "clock-xxx". > + compatible = "fixed-clock"; > + #clock-cells = <0>; > + clock-frequency = <27000000>; > + clock-output-names= "dpclk"; > + }; > + > + aclk: aclk { > + compatible = "fixed-clock"; > + #clock-cells = <0>; > + clock-frequency = <650000000>; > + clock-output-names= "aclk"; > + }; > + > + pclk: pclk { > + compatible = "fixed-clock"; > + #clock-cells = <0>; > + clock-frequency = <650000000>; > + clock-output-names= "pclk"; > + }; > + > reboot { > compatible ="syscon-reboot"; > regmap = <&dcfg>; > @@ -433,4 +454,20 @@ > }; > }; > }; > + > + dp0: malidp@f080000 { The node name should be something generic. The recommendation from Devicetree Specification is 'display'. > + compatible = "arm,mali-dp500"; > + reg = <0x0 0xf080000 0x0 0x10000>; > + interrupts = <0 222 IRQ_TYPE_LEVEL_HIGH>, > + <0 223 IRQ_TYPE_LEVEL_HIGH>; > + interrupt-names = "DE", "SE"; > + clocks = <&dpclk>, <&aclk>, <&aclk>, <&pclk>; > + clock-names = "pxlclk", "mclk", "aclk", "pclk"; > + arm,malidp-output-port-lines = /bits/ 8 <8 8 8>; Please have a newline between properties and child node. Shawn > + port { > + dp0_out: endpoint { > + > + }; > + }; > + }; > }; > -- > 2.17.1 >