* [PATCH 1/2] arm64: dts: ls1028a: Add properties for Mali DP500 node @ 2019-03-28 3:51 Wen He 2019-03-28 16:17 ` liviu.dudau 2019-04-03 10:14 ` Shawn Guo 0 siblings, 2 replies; 6+ messages in thread From: Wen He @ 2019-03-28 3:51 UTC (permalink / raw) To: devicetree@vger.kernel.org, shawnguo@kernel.org Cc: Leo Li, liviu.dudau@arm.com, brian.starkey@arm.com, Wen He The LS1028A has a LCD controller and Displayport interface that connects to eDP and Displayport connectors on the LS1028A board. This patch enables the LCD controller driver on the LS1028A. Signed-off-by: Alison Wang <alison.wang@nxp.com> Signed-off-by: Wen He <wen.he_1@nxp.com> --- .../arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 37 +++++++++++++++++++ 1 file changed, 37 insertions(+) diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi index 8dd3501b1333..0d5963bb46c5 100644 --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi @@ -70,6 +70,27 @@ clock-output-names = "sysclk"; }; + dpclk: dpclk { + compatible = "fixed-clock"; + #clock-cells = <0>; + clock-frequency = <27000000>; + clock-output-names= "dpclk"; + }; + + aclk: aclk { + compatible = "fixed-clock"; + #clock-cells = <0>; + clock-frequency = <650000000>; + clock-output-names= "aclk"; + }; + + pclk: pclk { + compatible = "fixed-clock"; + #clock-cells = <0>; + clock-frequency = <650000000>; + clock-output-names= "pclk"; + }; + reboot { compatible ="syscon-reboot"; regmap = <&dcfg>; @@ -433,4 +454,20 @@ }; }; }; + + dp0: malidp@f080000 { + compatible = "arm,mali-dp500"; + reg = <0x0 0xf080000 0x0 0x10000>; + interrupts = <0 222 IRQ_TYPE_LEVEL_HIGH>, + <0 223 IRQ_TYPE_LEVEL_HIGH>; + interrupt-names = "DE", "SE"; + clocks = <&dpclk>, <&aclk>, <&aclk>, <&pclk>; + clock-names = "pxlclk", "mclk", "aclk", "pclk"; + arm,malidp-output-port-lines = /bits/ 8 <8 8 8>; + port { + dp0_out: endpoint { + + }; + }; + }; }; -- 2.17.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] arm64: dts: ls1028a: Add properties for Mali DP500 node 2019-03-28 3:51 [PATCH 1/2] arm64: dts: ls1028a: Add properties for Mali DP500 node Wen He @ 2019-03-28 16:17 ` liviu.dudau 2019-04-03 10:14 ` Shawn Guo 1 sibling, 0 replies; 6+ messages in thread From: liviu.dudau @ 2019-03-28 16:17 UTC (permalink / raw) To: Wen He Cc: devicetree@vger.kernel.org, shawnguo@kernel.org, Leo Li, brian.starkey@arm.com On Thu, Mar 28, 2019 at 03:51:46AM +0000, Wen He wrote: > The LS1028A has a LCD controller and Displayport interface that > connects to eDP and Displayport connectors on the LS1028A board. > > This patch enables the LCD controller driver on the LS1028A. > > Signed-off-by: Alison Wang <alison.wang@nxp.com> > Signed-off-by: Wen He <wen.he_1@nxp.com> Reviewed-by: Liviu Dudau <liviu.dudau@arm.com> Best regards, Liviu > --- > .../arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 37 +++++++++++++++++++ > 1 file changed, 37 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > index 8dd3501b1333..0d5963bb46c5 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > @@ -70,6 +70,27 @@ > clock-output-names = "sysclk"; > }; > > + dpclk: dpclk { > + compatible = "fixed-clock"; > + #clock-cells = <0>; > + clock-frequency = <27000000>; > + clock-output-names= "dpclk"; > + }; > + > + aclk: aclk { > + compatible = "fixed-clock"; > + #clock-cells = <0>; > + clock-frequency = <650000000>; > + clock-output-names= "aclk"; > + }; > + > + pclk: pclk { > + compatible = "fixed-clock"; > + #clock-cells = <0>; > + clock-frequency = <650000000>; > + clock-output-names= "pclk"; > + }; > + > reboot { > compatible ="syscon-reboot"; > regmap = <&dcfg>; > @@ -433,4 +454,20 @@ > }; > }; > }; > + > + dp0: malidp@f080000 { > + compatible = "arm,mali-dp500"; > + reg = <0x0 0xf080000 0x0 0x10000>; > + interrupts = <0 222 IRQ_TYPE_LEVEL_HIGH>, > + <0 223 IRQ_TYPE_LEVEL_HIGH>; > + interrupt-names = "DE", "SE"; > + clocks = <&dpclk>, <&aclk>, <&aclk>, <&pclk>; > + clock-names = "pxlclk", "mclk", "aclk", "pclk"; > + arm,malidp-output-port-lines = /bits/ 8 <8 8 8>; > + port { > + dp0_out: endpoint { > + > + }; > + }; > + }; > }; > -- > 2.17.1 > -- ==================== | I would like to | | fix the world, | | but they're not | | giving me the | \ source code! / --------------- ¯\_(ツ)_/¯ ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] arm64: dts: ls1028a: Add properties for Mali DP500 node 2019-03-28 3:51 [PATCH 1/2] arm64: dts: ls1028a: Add properties for Mali DP500 node Wen He 2019-03-28 16:17 ` liviu.dudau @ 2019-04-03 10:14 ` Shawn Guo 2019-04-03 13:03 ` Wen He 1 sibling, 1 reply; 6+ messages in thread From: Shawn Guo @ 2019-04-03 10:14 UTC (permalink / raw) To: Wen He Cc: devicetree@vger.kernel.org, Leo Li, liviu.dudau@arm.com, brian.starkey@arm.com On Thu, Mar 28, 2019 at 03:51:46AM +0000, Wen He wrote: > The LS1028A has a LCD controller and Displayport interface that > connects to eDP and Displayport connectors on the LS1028A board. > > This patch enables the LCD controller driver on the LS1028A. > > Signed-off-by: Alison Wang <alison.wang@nxp.com> > Signed-off-by: Wen He <wen.he_1@nxp.com> > --- > .../arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 37 +++++++++++++++++++ > 1 file changed, 37 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > index 8dd3501b1333..0d5963bb46c5 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > @@ -70,6 +70,27 @@ > clock-output-names = "sysclk"; > }; > > + dpclk: dpclk { Please follow the naming convention "clock-xxx". > + compatible = "fixed-clock"; > + #clock-cells = <0>; > + clock-frequency = <27000000>; > + clock-output-names= "dpclk"; > + }; > + > + aclk: aclk { > + compatible = "fixed-clock"; > + #clock-cells = <0>; > + clock-frequency = <650000000>; > + clock-output-names= "aclk"; > + }; > + > + pclk: pclk { > + compatible = "fixed-clock"; > + #clock-cells = <0>; > + clock-frequency = <650000000>; > + clock-output-names= "pclk"; > + }; > + > reboot { > compatible ="syscon-reboot"; > regmap = <&dcfg>; > @@ -433,4 +454,20 @@ > }; > }; > }; > + > + dp0: malidp@f080000 { The node name should be something generic. The recommendation from Devicetree Specification is 'display'. > + compatible = "arm,mali-dp500"; > + reg = <0x0 0xf080000 0x0 0x10000>; > + interrupts = <0 222 IRQ_TYPE_LEVEL_HIGH>, > + <0 223 IRQ_TYPE_LEVEL_HIGH>; > + interrupt-names = "DE", "SE"; > + clocks = <&dpclk>, <&aclk>, <&aclk>, <&pclk>; > + clock-names = "pxlclk", "mclk", "aclk", "pclk"; > + arm,malidp-output-port-lines = /bits/ 8 <8 8 8>; Please have a newline between properties and child node. Shawn > + port { > + dp0_out: endpoint { > + > + }; > + }; > + }; > }; > -- > 2.17.1 > ^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH 1/2] arm64: dts: ls1028a: Add properties for Mali DP500 node 2019-04-03 10:14 ` Shawn Guo @ 2019-04-03 13:03 ` Wen He 2019-04-11 2:15 ` Shawn Guo 0 siblings, 1 reply; 6+ messages in thread From: Wen He @ 2019-04-03 13:03 UTC (permalink / raw) To: Shawn Guo Cc: devicetree@vger.kernel.org, Leo Li, liviu.dudau@arm.com, brian.starkey@arm.com > -----Original Message----- > From: Shawn Guo [mailto:shawnguo@kernel.org] > Sent: 2019年4月3日 18:14 > To: Wen He <wen.he_1@nxp.com> > Cc: devicetree@vger.kernel.org; Leo Li <leoyang.li@nxp.com>; > liviu.dudau@arm.com; brian.starkey@arm.com > Subject: Re: [PATCH 1/2] arm64: dts: ls1028a: Add properties for Mali DP500 > node > > On Thu, Mar 28, 2019 at 03:51:46AM +0000, Wen He wrote: > > The LS1028A has a LCD controller and Displayport interface that > > connects to eDP and Displayport connectors on the LS1028A board. > > > > This patch enables the LCD controller driver on the LS1028A. > > > > Signed-off-by: Alison Wang <alison.wang@nxp.com> > > Signed-off-by: Wen He <wen.he_1@nxp.com> > > --- > > .../arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 37 > > +++++++++++++++++++ > > 1 file changed, 37 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > > b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > > index 8dd3501b1333..0d5963bb46c5 100644 > > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > > @@ -70,6 +70,27 @@ > > clock-output-names = "sysclk"; > > }; > > > > + dpclk: dpclk { > > Please follow the naming convention "clock-xxx". > > > + compatible = "fixed-clock"; > > + #clock-cells = <0>; > > + clock-frequency = <27000000>; > > + clock-output-names= "dpclk"; > > + }; > > + > > + aclk: aclk { > > + compatible = "fixed-clock"; > > + #clock-cells = <0>; > > + clock-frequency = <650000000>; > > + clock-output-names= "aclk"; > > + }; > > + > > + pclk: pclk { > > + compatible = "fixed-clock"; > > + #clock-cells = <0>; > > + clock-frequency = <650000000>; > > + clock-output-names= "pclk"; > > + }; > > + > > reboot { > > compatible ="syscon-reboot"; > > regmap = <&dcfg>; > > @@ -433,4 +454,20 @@ > > }; > > }; > > }; > > + > > + dp0: malidp@f080000 { > > The node name should be something generic. The recommendation from > Devicetree Specification is 'display'. > That definition following by malidp Devicetree bindings file. If use name is 'display', how to define display port controller? this only is LCD controller dts node. > > + compatible = "arm,mali-dp500"; > > + reg = <0x0 0xf080000 0x0 0x10000>; > > + interrupts = <0 222 IRQ_TYPE_LEVEL_HIGH>, > > + <0 223 IRQ_TYPE_LEVEL_HIGH>; > > + interrupt-names = "DE", "SE"; > > + clocks = <&dpclk>, <&aclk>, <&aclk>, <&pclk>; > > + clock-names = "pxlclk", "mclk", "aclk", "pclk"; > > + arm,malidp-output-port-lines = /bits/ 8 <8 8 8>; > > Please have a newline between properties and child node. > > Shawn > Sure, but I see the mail devicetree binding doesn't have a blank line. So I removed it. Is need to add a newline? Best Regards, Wen > > + port { > > + dp0_out: endpoint { > > + > > + }; > > + }; > > + }; > > }; > > -- > > 2.17.1 > > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] arm64: dts: ls1028a: Add properties for Mali DP500 node 2019-04-03 13:03 ` Wen He @ 2019-04-11 2:15 ` Shawn Guo 2019-04-15 7:18 ` [EXT] " Wen He 0 siblings, 1 reply; 6+ messages in thread From: Shawn Guo @ 2019-04-11 2:15 UTC (permalink / raw) To: Wen He Cc: devicetree@vger.kernel.org, Leo Li, liviu.dudau@arm.com, brian.starkey@arm.com On Wed, Apr 03, 2019 at 01:03:17PM +0000, Wen He wrote: > > > > -----Original Message----- > > From: Shawn Guo [mailto:shawnguo@kernel.org] > > Sent: 2019年4月3日 18:14 > > To: Wen He <wen.he_1@nxp.com> > > Cc: devicetree@vger.kernel.org; Leo Li <leoyang.li@nxp.com>; > > liviu.dudau@arm.com; brian.starkey@arm.com > > Subject: Re: [PATCH 1/2] arm64: dts: ls1028a: Add properties for Mali DP500 > > node > > > > On Thu, Mar 28, 2019 at 03:51:46AM +0000, Wen He wrote: > > > The LS1028A has a LCD controller and Displayport interface that > > > connects to eDP and Displayport connectors on the LS1028A board. > > > > > > This patch enables the LCD controller driver on the LS1028A. > > > > > > Signed-off-by: Alison Wang <alison.wang@nxp.com> > > > Signed-off-by: Wen He <wen.he_1@nxp.com> > > > --- > > > .../arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 37 > > > +++++++++++++++++++ > > > 1 file changed, 37 insertions(+) > > > > > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > > > b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > > > index 8dd3501b1333..0d5963bb46c5 100644 > > > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > > > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > > > @@ -70,6 +70,27 @@ > > > clock-output-names = "sysclk"; > > > }; > > > > > > + dpclk: dpclk { > > > > Please follow the naming convention "clock-xxx". > > > > > + compatible = "fixed-clock"; > > > + #clock-cells = <0>; > > > + clock-frequency = <27000000>; > > > + clock-output-names= "dpclk"; > > > + }; > > > + > > > + aclk: aclk { > > > + compatible = "fixed-clock"; > > > + #clock-cells = <0>; > > > + clock-frequency = <650000000>; > > > + clock-output-names= "aclk"; > > > + }; > > > + > > > + pclk: pclk { > > > + compatible = "fixed-clock"; > > > + #clock-cells = <0>; > > > + clock-frequency = <650000000>; > > > + clock-output-names= "pclk"; > > > + }; > > > + > > > reboot { > > > compatible ="syscon-reboot"; > > > regmap = <&dcfg>; > > > @@ -433,4 +454,20 @@ > > > }; > > > }; > > > }; > > > + > > > + dp0: malidp@f080000 { > > > > The node name should be something generic. The recommendation from > > Devicetree Specification is 'display'. > > > > That definition following by malidp Devicetree bindings file. > If use name is 'display', how to define display port controller? this only is LCD controller dts node. We can use some sort of suffix to define multiple nodes: - display-0, display-1 ... - display-dp, display-lcd, ... Whatever suffix works for you, but begin with a generic name. > > > > + compatible = "arm,mali-dp500"; > > > + reg = <0x0 0xf080000 0x0 0x10000>; > > > + interrupts = <0 222 IRQ_TYPE_LEVEL_HIGH>, > > > + <0 223 IRQ_TYPE_LEVEL_HIGH>; > > > + interrupt-names = "DE", "SE"; > > > + clocks = <&dpclk>, <&aclk>, <&aclk>, <&pclk>; > > > + clock-names = "pxlclk", "mclk", "aclk", "pclk"; > > > + arm,malidp-output-port-lines = /bits/ 8 <8 8 8>; > > > > Please have a newline between properties and child node. > > > > Shawn > > > > Sure, but I see the mail devicetree binding doesn't have a blank line. So I removed it. > Is need to add a newline? Different bindings use different conventions, but we have a set of conventions for devicetree sources I maintain. Shawn ^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [EXT] Re: [PATCH 1/2] arm64: dts: ls1028a: Add properties for Mali DP500 node 2019-04-11 2:15 ` Shawn Guo @ 2019-04-15 7:18 ` Wen He 0 siblings, 0 replies; 6+ messages in thread From: Wen He @ 2019-04-15 7:18 UTC (permalink / raw) To: Shawn Guo Cc: devicetree@vger.kernel.org, Leo Li, liviu.dudau@arm.com, brian.starkey@arm.com > -----Original Message----- > From: Shawn Guo [mailto:shawnguo@kernel.org] > Sent: 2019年4月11日 10:16 > To: Wen He <wen.he_1@nxp.com> > Cc: devicetree@vger.kernel.org; Leo Li <leoyang.li@nxp.com>; > liviu.dudau@arm.com; brian.starkey@arm.com > Subject: [EXT] Re: [PATCH 1/2] arm64: dts: ls1028a: Add properties for Mali > DP500 node > > WARNING: This email was created outside of NXP. DO NOT CLICK links or > attachments unless you recognize the sender and know the content is safe. > > > > On Wed, Apr 03, 2019 at 01:03:17PM +0000, Wen He wrote: > > > > > > > -----Original Message----- > > > From: Shawn Guo [mailto:shawnguo@kernel.org] > > > Sent: 2019年4月3日 18:14 > > > To: Wen He <wen.he_1@nxp.com> > > > Cc: devicetree@vger.kernel.org; Leo Li <leoyang.li@nxp.com>; > > > liviu.dudau@arm.com; brian.starkey@arm.com > > > Subject: Re: [PATCH 1/2] arm64: dts: ls1028a: Add properties for > > > Mali DP500 node > > > > > > On Thu, Mar 28, 2019 at 03:51:46AM +0000, Wen He wrote: > > > > The LS1028A has a LCD controller and Displayport interface that > > > > connects to eDP and Displayport connectors on the LS1028A board. > > > > > > > > This patch enables the LCD controller driver on the LS1028A. > > > > > > > > Signed-off-by: Alison Wang <alison.wang@nxp.com> > > > > Signed-off-by: Wen He <wen.he_1@nxp.com> > > > > --- > > > > .../arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 37 > > > > +++++++++++++++++++ > > > > 1 file changed, 37 insertions(+) > > > > > > > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > > > > b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > > > > index 8dd3501b1333..0d5963bb46c5 100644 > > > > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > > > > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > > > > @@ -70,6 +70,27 @@ > > > > clock-output-names = "sysclk"; > > > > }; > > > > > > > > + dpclk: dpclk { > > > > > > Please follow the naming convention "clock-xxx". > > > > > > > + compatible = "fixed-clock"; > > > > + #clock-cells = <0>; > > > > + clock-frequency = <27000000>; > > > > + clock-output-names= "dpclk"; }; > > > > + > > > > + aclk: aclk { > > > > + compatible = "fixed-clock"; > > > > + #clock-cells = <0>; > > > > + clock-frequency = <650000000>; > > > > + clock-output-names= "aclk"; }; > > > > + > > > > + pclk: pclk { > > > > + compatible = "fixed-clock"; > > > > + #clock-cells = <0>; > > > > + clock-frequency = <650000000>; > > > > + clock-output-names= "pclk"; }; > > > > + > > > > reboot { > > > > compatible ="syscon-reboot"; > > > > regmap = <&dcfg>; > > > > @@ -433,4 +454,20 @@ > > > > }; > > > > }; > > > > }; > > > > + > > > > + dp0: malidp@f080000 { > > > > > > The node name should be something generic. The recommendation from > > > Devicetree Specification is 'display'. > > > > > > > That definition following by malidp Devicetree bindings file. > > If use name is 'display', how to define display port controller? this only is LCD > controller dts node. > > We can use some sort of suffix to define multiple nodes: > > - display-0, display-1 ... > - display-dp, display-lcd, ... > > Whatever suffix works for you, but begin with a generic name. > Understood, > > > > > > + compatible = "arm,mali-dp500"; > > > > + reg = <0x0 0xf080000 0x0 0x10000>; > > > > + interrupts = <0 222 IRQ_TYPE_LEVEL_HIGH>, > > > > + <0 223 IRQ_TYPE_LEVEL_HIGH>; > > > > + interrupt-names = "DE", "SE"; > > > > + clocks = <&dpclk>, <&aclk>, <&aclk>, <&pclk>; > > > > + clock-names = "pxlclk", "mclk", "aclk", "pclk"; > > > > + arm,malidp-output-port-lines = /bits/ 8 <8 8 8>; > > > > > > Please have a newline between properties and child node. > > > > > > Shawn > > > > > > > Sure, but I see the mail devicetree binding doesn't have a blank line. So I > removed it. > > Is need to add a newline? > > Different bindings use different conventions, but we have a set of conventions > for devicetree sources I maintain. > Got it, will sent another patch. Thank you. Best Regards, Wen > Shawn ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-04-15 7:19 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2019-03-28 3:51 [PATCH 1/2] arm64: dts: ls1028a: Add properties for Mali DP500 node Wen He 2019-03-28 16:17 ` liviu.dudau 2019-04-03 10:14 ` Shawn Guo 2019-04-03 13:03 ` Wen He 2019-04-11 2:15 ` Shawn Guo 2019-04-15 7:18 ` [EXT] " Wen He
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).